From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D858C49EA5 for ; Fri, 25 Jun 2021 01:57:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C41DB608FE for ; Fri, 25 Jun 2021 01:57:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C41DB608FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD79C6B005D; Thu, 24 Jun 2021 21:57:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C888F6B006C; Thu, 24 Jun 2021 21:57:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B776F6B0070; Thu, 24 Jun 2021 21:57:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id 888C36B005D for ; Thu, 24 Jun 2021 21:57:51 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B323682F2509 for ; Fri, 25 Jun 2021 01:57:51 +0000 (UTC) X-FDA: 78290585142.02.F2D5951 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 562D8E000253 for ; Fri, 25 Jun 2021 01:57:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MXjKTNHOnjltT/dot/g0YTpYEVLMdUkJzO1LZTVDP6o=; b=JZhNvXWvrjI4O4uDc3UFXGdV6+ 6qiO/mBCCwvyi9o5MzFKjhi271ph7C+nds62urru+bHOUPNaTv/1PJQpTjSwbKNkP0qPttjibrZI6 lEVx1xji8mb51FWW0rLvgp8CdyYSQo0ghjYDuqcB+MXq9KY8DAZdYrZdXecj7qnVlWolkM5iZfcmO MhfpnOFM+47D67scmXfYV8tv2z97pEM6u19Ii1MtmufPshdMkSxUrAVx2ziAlhZjiv7quQO5KGgn5 QS2X50QIHG0cQ5lSJ8ogV8/0xcLgL+6CPww/br5vmRUZ9xzpYl4JsYD6sLvyTnrUR1Cwj19bb70eH 2CpZoB2g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwb5s-00HDJz-Cr; Fri, 25 Jun 2021 01:57:22 +0000 Date: Fri, 25 Jun 2021 02:57:20 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 43/46] mm/filemap: Add filemap_add_folio Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-44-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JZhNvXWv; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Rspamd-Server: rspam02 X-Stat-Signature: pzkq3j3pagxs7eobtkuzqnqzgudnr9zp X-Rspamd-Queue-Id: 562D8E000253 X-HE-Tag: 1624586271-558637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 01:30:04PM +0200, Christoph Hellwig wrote: > On Tue, Jun 22, 2021 at 01:15:48PM +0100, Matthew Wilcox (Oracle) wrote: > > Pages being added to the page cache should already be folios, so > > just cast the page to a folio in the add_to_page_cache_lru() wrapper. > > Saves 96 bytes of text. > > modulo the casting: ok. Moved add_to_page_cache_lru() into folio-compat.c, added the call to page_folio() and also added: if (!huge) { + VM_BUG_ON_FOLIO(index & (folio_nr_pages(folio) - 1), folio); error = folio_charge_cgroup(folio, current->mm, gfp); as we don't want pages added at an unaligned index in the file. > Reviewed-by: Christoph Hellwig