From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DBF3C49EAF for ; Thu, 24 Jun 2021 23:46:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DF02B613C0 for ; Thu, 24 Jun 2021 23:46:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF02B613C0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 21D876B005D; Thu, 24 Jun 2021 19:46:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F4476B006C; Thu, 24 Jun 2021 19:46:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E2FB6B0070; Thu, 24 Jun 2021 19:46:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id D51E86B005D for ; Thu, 24 Jun 2021 19:46:40 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0EDDF24389 for ; Thu, 24 Jun 2021 23:46:41 +0000 (UTC) X-FDA: 78290254602.21.118CD9C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf09.hostedemail.com (Postfix) with ESMTP id F01C06000147 for ; Thu, 24 Jun 2021 23:46:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QRrsLI7GGtnqIpUE1NhSb681pP7OUT+FkfN9iRVIhgw=; b=GJ0asLtE8az/ZgBHMAI9w7Prf9 L8WTI6fB1EWZRk/qyvEREMqkwJ8oywPKhvvgUyUDoAuQTHIrV8iDR4fYiUe1l9UoYKJRDkO5um6gh GUf86KTBuZhSqe0iSC8d6BUCqdKniy7grkD91FLG/Hef7gDnCXp3j8d2Ymc7iCaSKvVObDSHGIhls oHkxLDdhceP/dTqsszWlTnQ72hg0QMcJvR9TtJXio2dVUT0ys6IxASFmxoi2hWrfiZBlMsT70jhCt 08Ey8o1J97NPj00WRZA9qWrmqiGSD/3dcovCMX1cPFwL58IDh9gR9GY8vW6w+xW1lSgDtsQfHv+Va 834cJ0Hg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwZ2v-00H7K5-3Q; Thu, 24 Jun 2021 23:46:12 +0000 Date: Fri, 25 Jun 2021 00:46:09 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 36/46] mm/filemap: Add readahead_folio() Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-37-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: F01C06000147 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GJ0asLtE; spf=none (imf09.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: 5uhbcr64yy38xwmxetpmrh3h3wdbysf5 X-HE-Tag: 1624578399-689525 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 23, 2021 at 11:50:04AM +0200, Christoph Hellwig wrote: > On Tue, Jun 22, 2021 at 01:15:41PM +0100, Matthew Wilcox (Oracle) wrote: > > The pointers stored in the page cache are folios, by definition. > > This change comes with a behaviour change -- callers of readahead_folio() > > are no longer required to put the page reference themselves. This matches > > how readpage works, rather than matching how readpages used to work. > > The way this stores and retrieves different but compatible types from the > same xarray is a little nasty. But I guess we'll have to live with it for > now, so: I think that's mostly fixed up by the end of this series. I think there's still a few bits which are currently postponed to series 4 (eg uses of __page_cache_alloc followed by add_to_page_cache_lru). > Reviewed-by: Christoph Hellwig