From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FBDDC2B9F4 for ; Mon, 28 Jun 2021 06:27:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD1CB61945 for ; Mon, 28 Jun 2021 06:27:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD1CB61945 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 00CC88D0024; Mon, 28 Jun 2021 02:27:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFEF08D0016; Mon, 28 Jun 2021 02:27:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9FFB8D0024; Mon, 28 Jun 2021 02:27:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id A89888D0016 for ; Mon, 28 Jun 2021 02:27:07 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 019228249980 for ; Mon, 28 Jun 2021 06:27:06 +0000 (UTC) X-FDA: 78302150052.24.F8FCF50 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 82F3C41449C3 for ; Mon, 28 Jun 2021 06:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kqPl8uKKTkQd95xx1nWpD57BeJxJwc5506fBPRake+o=; b=bjTS2gc/xpKd25m6OAYICQUS9j /uUwFApxw1ahiUWKxhO0XmORRnTfDqEnn2gf2RWXpXMP7CX9l8o8mNY2b4t6lATGRGBgogxdvUl+9 xTAFIrUWoa45zB6hbLmc6KGpNODIq1KYtR8s3FObTmoA4mpKRZzUonTshbCuPxZsRecSxUQZNJb/c xR18MsOLzUiRdz+kkcUYd/C3W6db8yr+qb8JtOtMoH7JrnouybsiaZgnMOW3QCFmEF/YvgUNu2Swe YO23dxDeSo2tevOrHSO6QYEcfKhh1mA2VEu0cR/N/2vW8c9JEZAiO+XiWpuSQiOox69XZfjtfe0gS z3S+lDIQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1lxkhB-002eg2-Fe; Mon, 28 Jun 2021 06:24:46 +0000 Date: Mon, 28 Jun 2021 07:24:37 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 17/46] mm/memcg: Convert mem_cgroup_track_foreign_dirty_slowpath() to folio Message-ID: References: <20210622121551.3398730-1-willy@infradead.org> <20210622121551.3398730-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="bjTS2gc/"; spf=none (imf17.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Stat-Signature: 1jf9tg4d7qqgh5mnh8e6woik86txbaf1 X-Rspamd-Queue-Id: 82F3C41449C3 X-Rspamd-Server: rspam06 X-HE-Tag: 1624861625-679003 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 24, 2021 at 06:37:47PM +0100, Matthew Wilcox wrote: > On Wed, Jun 23, 2021 at 10:21:26AM +0200, Christoph Hellwig wrote: > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > Although I wish we could come up with a shorter name for > > mem_cgroup_track_foreign_dirty_slowpath somehow.. > > It is quite grotesque! > > How about folio_track_foreign_writeback() as a replacement name for > mem_cgroup_track_foreign_dirty() and have it call > __folio_track_foreign_writeback()? > > Although 'foreign' tends to be used in MM to mean "wrong NUMA node", > so maybe that's misleading. folio_track_dirty_cgroup()? > folio_mark_dirty_cgroup()? (the last to be read in context of > __set_page_dirty() being renamed to __folio_mark_dirty()) That all sounds reasonable to me, hopefully someone more attached to this code can pick one.