From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED5B9C4338F for ; Mon, 26 Jul 2021 03:26:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39D5660F02 for ; Mon, 26 Jul 2021 03:26:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 39D5660F02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 98C7C6B0033; Sun, 25 Jul 2021 23:26:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 93C2A8D0002; Sun, 25 Jul 2021 23:26:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 851C58D0001; Sun, 25 Jul 2021 23:26:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id 68F746B0033 for ; Sun, 25 Jul 2021 23:26:05 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0CB088249980 for ; Mon, 26 Jul 2021 03:26:05 +0000 (UTC) X-FDA: 78403300290.09.AC15F70 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id DB3A3D019530 for ; Mon, 26 Jul 2021 03:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RAkBaJcAPELwC1B8vW73sx7vizUe93GJAbJNf3OG52M=; b=VMhfcOenwLocwQgQFJRBi6pOF6 UDsA1qkO06DXplKF1DK1+mmux5fNS0BbB+g/1x5Tjn+Jdd+/rxEIx5FM+5PVR4StyB0Ht8B0X0IQB uLZOOHhtbtneM6GDfaHeHHyWTaDMR7IhluBwJkh01zAEUhXKmUiUJ0r3b72gYz018sbPFKsZad3J5 hAWyOWY5DgMF+5TjOe6zkib+Q7r4LcfWxustvpsXI82S064qpDfUBapEGXc0OQY9FJeO2IECz4g+o cNHFz9KyURgqwAZjPQZkAwLJEdmbJx+4rlOQlCesQqFOpMGloYeVuRstkEOz9SIZeZVNhsUPP/tDX 5o2GuvQg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7rFL-00DYm4-34; Mon, 26 Jul 2021 03:25:42 +0000 Date: Mon, 26 Jul 2021 04:25:39 +0100 From: Matthew Wilcox To: Chen Wandun Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, weiyongjun1@huawei.com Subject: Re: [PATCH] mm/vmalloc: add missing __GFP_HIGHMEM flag for vmalloc Message-ID: References: <20210726032333.3404164-1-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210726032333.3404164-1-chenwandun@huawei.com> Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=VMhfcOen; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DB3A3D019530 X-Stat-Signature: h3upn4jrtubzj35cr9chsikbn1gqr38c X-HE-Tag: 1627269963-492238 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 26, 2021 at 11:23:33AM +0800, Chen Wandun wrote: > struct page array can also be allocated in highmem during vmalloc, > that will ease the low memory stress in 32bit system. Huh? Where does it get kmapped in order to access it? > Fixes: f255935b9767 ("mm: cleanup the gfp_mask handling in __vmalloc_area_node") > Signed-off-by: Chen Wandun > --- > mm/vmalloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3824dc16ce1c..8d9b0b08a6dc 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2885,7 +2885,8 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > > /* Please note that the recursion is strictly bounded. */ > if (array_size > PAGE_SIZE) { > - area->pages = __vmalloc_node(array_size, 1, nested_gfp, node, > + area->pages = __vmalloc_node(array_size, 1, > + nested_gfp | __GFP_HIGHMEM, node, > area->caller); > } else { > area->pages = kmalloc_node(array_size, nested_gfp, node); > -- > 2.25.1 > >