From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21276C07E96 for ; Thu, 15 Jul 2021 12:59:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A319C60FEB for ; Thu, 15 Jul 2021 12:59:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A319C60FEB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1E038D00BB; Thu, 15 Jul 2021 08:59:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCE708D0065; Thu, 15 Jul 2021 08:59:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6F388D00BB; Thu, 15 Jul 2021 08:59:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 7FF568D0065 for ; Thu, 15 Jul 2021 08:59:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 64FDE183E6C68 for ; Thu, 15 Jul 2021 12:59:51 +0000 (UTC) X-FDA: 78364829382.01.C1E7645 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 68E9A1006EC2 for ; Thu, 15 Jul 2021 12:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=zEE2nfRfHuUPirbJkDMcOoVwEDE+zjPwjDDORrIirKk=; b=BL8T/G9GnAZDrpcJeud1pe4uRj ATOguswZSWPE75WODgr2IDqJni49D1lvCTSeg9hW/z0Xj6gzwQAgLvXAAYjvMpygC3FxToq3Q+WHA GMrzHIZAWzIo9qdQg8jOCST9EbAsV2K1p4GAzxuEaV7w9LrRHHFZ8XmykgTmNtOFKWm7fXo6svmKT M0PgRf7DueoCNHiY8CwwBvOpRKNxYhaNHbwIVoVIZ/jA1Hbl59Cu9jLN4pp2YrceTUydr8TBDrCZ7 kvBOxWKwbqslJy9MBupzFMOB1N0abOaT880jjZ9KGlnj7uRq0SyOeq5TsCq4X2rzqaKE1iW7qIlR0 lTHqb1BQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m40xF-003MIx-3g; Thu, 15 Jul 2021 12:59:13 +0000 Date: Thu, 15 Jul 2021 13:59:05 +0100 From: Christoph Hellwig To: Dan Williams Cc: Joao Martins , Linux MM , Vishal Verma , Dave Jiang , Naoya Horiguchi , Matthew Wilcox , Jason Gunthorpe , John Hubbard , Jane Chu , Muchun Song , Mike Kravetz , Andrew Morton , Jonathan Corbet , Linux NVDIMM , Linux Doc Mailing List Subject: Re: [PATCH v3 04/14] mm/memremap: add ZONE_DEVICE support for compound pages Message-ID: References: <20210714193542.21857-1-joao.m.martins@oracle.com> <20210714193542.21857-5-joao.m.martins@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 68E9A1006EC2 X-Stat-Signature: 9e88wjf5n17a19r9gdrsirpacy7ahh41 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="BL8T/G9G"; spf=none (imf12.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-HE-Tag: 1626353989-391323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 14, 2021 at 06:08:14PM -0700, Dan Williams wrote: > > +static inline unsigned long pgmap_geometry(struct dev_pagemap *pgmap) > > +{ > > + if (!pgmap || !pgmap->geometry) > > + return PAGE_SIZE; > > + return pgmap->geometry; > > +} > > + > > +static inline unsigned long pgmap_pfn_geometry(struct dev_pagemap *pgmap) > > +{ > > + return PHYS_PFN(pgmap_geometry(pgmap)); > > +} > > Are both needed? Maybe just have ->geometry natively be in nr_pages > units directly, because pgmap_pfn_geometry() makes it confusing > whether it's a geometry of the pfn or the geometry of the pgmap. Actually - do we need non-power of two sizes here? Otherwise a shift for the pfns would be really nice as that simplifies a lot of the calculations.