From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA27C636CA for ; Thu, 15 Jul 2021 18:39:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 88C56613C3 for ; Thu, 15 Jul 2021 18:39:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88C56613C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E05778D00F4; Thu, 15 Jul 2021 14:39:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDCB58D00EC; Thu, 15 Jul 2021 14:39:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C563E8D00F4; Thu, 15 Jul 2021 14:39:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id A2DBB8D00EC for ; Thu, 15 Jul 2021 14:39:19 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7798718288A36 for ; Thu, 15 Jul 2021 18:39:18 +0000 (UTC) X-FDA: 78365684796.34.212BDA7 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by imf30.hostedemail.com (Postfix) with ESMTP id 324C7E001819 for ; Thu, 15 Jul 2021 18:39:18 +0000 (UTC) Received: by mail-pg1-f175.google.com with SMTP id y17so7398879pgf.12 for ; Thu, 15 Jul 2021 11:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=f3Y0+ogDVT6wqAQ9ZQs2NyHc5pJHUCbPNwTdIK9PvNA=; b=Qv3S59LCo5Nmv9xeE85vyXWs0GZOA6KpAsz49t1UEOxMwgH2P9Y4ljAK74msMmTt2O UNWvggYks0hDjPx8QyMfkCWn1CjZq5S9eiunJ77QL6TXq8rwRbAtkjCrdhgbFBYUHgxn L09H6z5RM3mwM5tX1LZl0rsd/lRhtL/FHHzGNIW6VhH3AJY+KQQ3s+h2yPt5segk0grk 8v5UWFkaC2eF83kmN+zNi9f9KERgDwDm+RB+yjbQirrVge0ZjGQhKibLQ48L41+LPY+j 7ZDohtKMPav2yX+ZJlS4XbJ63NiCsEP02INCQtD+ISzPHyO6hXsIkY+T4rbRtxzv5vb1 fVSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f3Y0+ogDVT6wqAQ9ZQs2NyHc5pJHUCbPNwTdIK9PvNA=; b=LYbXQbm6L76yYHFkA/LpOX4tprxK9ZHPIiA0YniNkVgu0X79mQ3wXfl5ohLr+LxVlZ RW3Wl9CEQquzOIhKt8U7l3JBaGfBi8wDSE0tN6zqKJdBy2uzDdldjlE8Fgo6kXFVtMDG 6rFmAt996I38IMSx1mgYs19hlxB1o7a+txRxo8qx7TrJ/qISMM0rpXz9PMXmnsABeOB9 h/vd74VW8uQdel40KsKl8OTuG4D+2J4jfywE05nvO6ZNWjFUG4gR4c5ClxF1/F4R/TM5 NiKuivldVSK1VpJodRlDVPDaCTDd3f+Muwzq8hr7vGoxYUTb5SSLWjfhNHrqr2mO/t5w 5djA== X-Gm-Message-State: AOAM5334xqupZnE6LPcf2BeiufLfzaER3Lz1kJtGend9MT5AiEpRxSC0 B6ViETqPnY+amqYqXb6h59kxeQ== X-Google-Smtp-Source: ABdhPJz+1iaVBL+ABO/O1tBChzrqhVRnDYERNo2Clv19fhDRGqCjbjbdtc1OIE70QPX9w7Agiv3K8Q== X-Received: by 2002:a62:19c9:0:b029:32a:129f:542d with SMTP id 192-20020a6219c90000b029032a129f542dmr5859523pfz.8.1626374356838; Thu, 15 Jul 2021 11:39:16 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id 73sm6267842pjz.24.2021.07.15.11.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 11:39:16 -0700 (PDT) Date: Thu, 15 Jul 2021 18:39:12 +0000 From: Sean Christopherson To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com Subject: Re: [PATCH Part2 RFC v4 07/40] x86/sev: Split the physmap when adding the page in RMP table Message-ID: References: <20210707183616.5620-1-brijesh.singh@amd.com> <20210707183616.5620-8-brijesh.singh@amd.com> <41f83ddf-a8a5-daf3-dc77-15fc164f77c6@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41f83ddf-a8a5-daf3-dc77-15fc164f77c6@amd.com> Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=Qv3S59LC; spf=pass (imf30.hostedemail.com: domain of seanjc@google.com designates 209.85.215.175 as permitted sender) smtp.mailfrom=seanjc@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam05 X-Stat-Signature: kiko5a5bwqqwrpu4mznt4ey7efhh4kdp X-Rspamd-Queue-Id: 324C7E001819 X-HE-Tag: 1626374358-226207 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021, Brijesh Singh wrote: > The memfd_secrets uses the set_direct_map_{invalid,default}_noflush() and it > is designed to remove/add the present bit in the direct map. We can't use > them, because in our case the page may get accessed by the KVM (e.g > kvm_guest_write, kvm_guest_map etc). But KVM should never access a guest private page, i.e. the direct map should always be restored to PRESENT before KVM attempts to access the page.