From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61AFEC636CB for ; Fri, 16 Jul 2021 02:56:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 06FA5613DF for ; Fri, 16 Jul 2021 02:56:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06FA5613DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4C29B8D00F4; Thu, 15 Jul 2021 22:56:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 471F38D00EC; Thu, 15 Jul 2021 22:56:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33ABF8D00F4; Thu, 15 Jul 2021 22:56:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 0B8C48D00EC for ; Thu, 15 Jul 2021 22:56:43 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CE1048248D7C for ; Fri, 16 Jul 2021 02:56:41 +0000 (UTC) X-FDA: 78366938202.02.6EDC646 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 382D35012912 for ; Fri, 16 Jul 2021 02:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mq3wTgxZEH4QjjVWOJ11+pesVGFg8c21USpyyqDfH2c=; b=US/J81dKvyj3XraQz7j/+lGQ4Z cTeopUgtkoIGZ2vozywVhGZjGkmPudXnlTVoT5F/+KDreUWuz0vTUa30IPEpKlPCLBy4n+qh3Qlzk jmDWlcYNDNpsytiPJahTck5WFxpluOYgE8N8TNMBq0nIPyki3s/GD2pCY4rAAqlBQBoMmExKUGeno oU2dJtqFJsod9rHDEMbNBWMV9CC8MqLWd21ONFlMki2uWn+Cb0N2NuWeP6PJRzLThxRKzAoJXeijZ Ny1rZx+F07h/ZHRIUxaOkh+5zYAnNvSnIJoaoZ9qHQ1Uc1+q0sW55SR5IN8yRG0WKW9QCptCAoFTo XX1kZukA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4E0y-0045Gl-CZ; Fri, 16 Jul 2021 02:55:57 +0000 Date: Fri, 16 Jul 2021 03:55:48 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 105/138] iomap: Convert iomap_add_to_ioend to take a folio Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-106-willy@infradead.org> <20210715220120.GP22357@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715220120.GP22357@magnolia> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 382D35012912 X-Stat-Signature: gedr9gau3eb4hubonxdy5m8b6czi5dnb Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="US/J81dK"; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1626404201-164125 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 03:01:20PM -0700, Darrick J. Wong wrote: > On Thu, Jul 15, 2021 at 04:36:31AM +0100, Matthew Wilcox (Oracle) wrote: > > > > - merged = __bio_try_merge_page(wpc->ioend->io_bio, page, len, poff, > > - &same_page); > > if (iop) > > atomic_add(len, &iop->write_bytes_pending); > > - > > - if (!merged) { > > - if (bio_full(wpc->ioend->io_bio, len)) { > > - wpc->ioend->io_bio = > > - iomap_chain_bio(wpc->ioend->io_bio); > > - } > > - bio_add_page(wpc->ioend->io_bio, page, len, poff); > > + if (!bio_add_folio(wpc->ioend->io_bio, folio, len, poff)) { > > + wpc->ioend->io_bio = iomap_chain_bio(wpc->ioend->io_bio); > > + bio_add_folio(wpc->ioend->io_bio, folio, len, poff); > > The paranoiac in me wonders if we ought to have some sort of error > checking here just in case we encounter double failures? Maybe? We didn't have it before, and it's just been allocated. I'd defer to Christoph here. > > - for (i = 0, file_offset = page_offset(page); > > - i < (PAGE_SIZE >> inode->i_blkbits) && file_offset < end_offset; > > - i++, file_offset += len) { > > + for (i = 0; i < nblocks; i++, pos += len) { > > + if (pos >= end_offset) > > + break; > > Any particular reason this isn't: > > for (i = 0; i < nblocks && pos < end_offset; i++, pos += len) { > > ? Just mild personal preference ... I don't even like having the pos += len in there. But you're maintainer, I'll shuffle that in. > Everything from here on out looks decent to me. Thanks!