From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38EDCC07E95 for ; Mon, 19 Jul 2021 20:24:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B617660FDC for ; Mon, 19 Jul 2021 20:24:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B617660FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 536A68D00F4; Mon, 19 Jul 2021 16:24:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E72B8D00EC; Mon, 19 Jul 2021 16:24:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3608F8D00F4; Mon, 19 Jul 2021 16:24:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 0FD3D8D00EC for ; Mon, 19 Jul 2021 16:24:53 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 90684274B4 for ; Mon, 19 Jul 2021 20:24:51 +0000 (UTC) X-FDA: 78380465982.05.1072A2E Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf02.hostedemail.com (Postfix) with ESMTP id 4A2B07001A24 for ; Mon, 19 Jul 2021 20:24:51 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id o201so17593972pfd.1 for ; Mon, 19 Jul 2021 13:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=/ueH7e1R+Y/9Tjm+iXp9T6qooVmg3C+ED64P3I591HI=; b=rpRYvrfz6uIHeUpHKmujhCdwk9rbm/oL9LmMIjkgkvoLoy4OntrYE11Df5glviaYn+ 6C0Q64khcfMxVcXVTZZJn0FhXZsMIWu7qge2Ikf+ANhdDMCuolK0QajXqXOPTNNHQZdC y/xBvL7a5FL6SqIsOmmCdR8XBrRAJI17s57sbB5vZLH7VyKT5Kd02Df0zVHtq3PHedc2 AYGbSnbqVtsE8UGU6HqfkIJfnpR8FHr2WEGoUKQqEJb0tyMcLPVkbr0kfMMru3LYCdSj TFMutp7A6eXjOdVSWKArL+d8R0xMsMIgFPkOWgSOt7A4IDqP9TdzUq3FT9hlrYbGTz3z kCxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/ueH7e1R+Y/9Tjm+iXp9T6qooVmg3C+ED64P3I591HI=; b=Ic3k2NMREcyhMAlmHiG8uqMXUSWf8RrqjzlQuKrzraVVX/2npuPcp6puyuxB+UCLQ9 O4iFv7wBTF+JoPRpnCe/pkFxOcKmYh5XsFYmyXw7/A0xCJQqZxeJQ8IPStvqFZb7xNJH KEW+desZToMRZxSsBhmDxKsPtzbMvJaMO0FjEQVlod3FJGw64mf07bKfwAHXq83KkccF wUD+1ZH1+o0FtB/d1CYZeA1xnCSKYQEpGtnbiCgzbPqbapkfYy7PmX1iBaiHwWErOu40 TC12vxJnBhQ6UvNQ41vWZmhwMwyVx1NEJv97gEZ88ANKm2YHVOH3VkPoRl5l0wddquEx QJ3w== X-Gm-Message-State: AOAM531bLB3N8OxQ97VcJnVEmk7BfK415G0oplewcyPTg9+zraWDJf2n uN5B57tXuKjZ7wwZJBZjGkiTdg== X-Google-Smtp-Source: ABdhPJx5z2KfcuWt/DfKkC4lsDSx4E1hp1htq+WW2Tom9he1jw05rOfD+bqBAYmCI98dUfs6qLi1hw== X-Received: by 2002:a62:1a47:0:b029:328:cbf8:6d42 with SMTP id a68-20020a621a470000b0290328cbf86d42mr27228516pfa.37.1626726290119; Mon, 19 Jul 2021 13:24:50 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id n6sm23363563pgb.60.2021.07.19.13.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 13:24:49 -0700 (PDT) Date: Mon, 19 Jul 2021 20:24:45 +0000 From: Sean Christopherson To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , tony.luck@intel.com, npmccallum@redhat.com, brijesh.ksingh@gmail.com Subject: Re: [PATCH Part2 RFC v4 22/40] KVM: SVM: Add KVM_SNP_INIT command Message-ID: References: <20210707183616.5620-1-brijesh.singh@amd.com> <20210707183616.5620-23-brijesh.singh@amd.com> <3f12243a-dee3-2a97-9a1b-51f4f6095349@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <3f12243a-dee3-2a97-9a1b-51f4f6095349@amd.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4A2B07001A24 X-Stat-Signature: tw4kjxwyqmtb9u5yhk5yb7d7p9efdnp8 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=rpRYvrfz; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of seanjc@google.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=seanjc@google.com X-HE-Tag: 1626726291-529276 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 16, 2021, Brijesh Singh wrote: >=20 > On 7/16/21 2:33 PM, Sean Christopherson wrote: > > On Wed, Jul 07, 2021, Brijesh Singh wrote: > >> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > >> index 3fd9a7e9d90c..989a64aa1ae5 100644 > >> --- a/include/uapi/linux/kvm.h > >> +++ b/include/uapi/linux/kvm.h > >> @@ -1678,6 +1678,9 @@ enum sev_cmd_id { > >> /* Guest Migration Extension */ > >> KVM_SEV_SEND_CANCEL, > >> =20 > >> + /* SNP specific commands */ > >> + KVM_SEV_SNP_INIT =3D 256, > > Is there any meaning behind '256'? If not, why skip a big chunk? I = wouldn't be > > concerned if it weren't for KVM_SEV_NR_MAX, whose existence arguably = implies that > > 0-KVM_SEV_NR_MAX-1 are all valid SEV commands. >=20 > In previous patches, Peter highlighted that we should keep some gap > between the SEV/ES and SNP to leave room for legacy SEV/ES expansion. I > was not sure how many we need to reserve without knowing what will come > in the future; especially recently some of the command additional=A0 ar= e > not linked to the firmware. I am okay to reduce the gap or remove the > gap all together. Unless the numbers themselves have meaning, which I don't think they do, = I vote to keep the arbitrary numbers contiguous. KVM_SEV_NR_MAX makes me nervou= s, and there are already cases of related commands being discontiguous, e.g. KVM= _SEND_CANCEL. Peter or Paolo, any thoughts?