From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A60F2C07E95 for ; Tue, 20 Jul 2021 06:50:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 62B436113B for ; Tue, 20 Jul 2021 06:50:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62B436113B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0822B6B0093; Tue, 20 Jul 2021 02:50:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 032276B00DA; Tue, 20 Jul 2021 02:50:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3C466B00DC; Tue, 20 Jul 2021 02:50:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id B5FCB6B0093 for ; Tue, 20 Jul 2021 02:50:32 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 43D281AEC8 for ; Tue, 20 Jul 2021 06:50:31 +0000 (UTC) X-FDA: 78382042662.13.0ED36A7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id A8A81B00046F for ; Tue, 20 Jul 2021 06:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lMtcatGAyLABwHy0lFwp2XqMHE37vGNK4KvilrkVbV8=; b=t0kTfT+1W8U+XE7LNqb14lUUvc u3PVhyjAKrd03M9aIGVfPFzbq0ec6mYLLZH1yd3nA3sXo1yYS1ddJp844GJbeTv0cKoAR6tJDDvMq 8RINMfMTRJ9gJA/uTWkPyS/NrOduxJMuBWoGLjyUQjd2Govtw8idxNC7GEs1kW/lDJ7WWGEdPkxuT 0Yo5UBGy9uaKGgivknw47KJq0dxNPUWgduz5sK83Gip8rUEBwFWA/ftNce/bQ6zqY+uAtWb4bNOv/ DRSKxq5Zq87/U6UjS5DgBuY7b8BxcV0FVNjL6ezH0rgY0tNe7yFMGv0shdQOdLlbjgzZ/yu9MxP48 r6RWEOdA==; Received: from [2001:4bb8:193:7660:5612:5e3c:ba3d:2b3c] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5jZM-007q94-W9; Tue, 20 Jul 2021 06:49:47 +0000 Date: Tue, 20 Jul 2021 08:49:32 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, "Darrick J . Wong" Subject: Re: [PATCH v15 03/17] iomap: Convert to_iomap_page to take a folio Message-ID: References: <20210719184001.1750630-1-willy@infradead.org> <20210719184001.1750630-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719184001.1750630-4-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=t0kTfT+1; spf=none (imf19.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Stat-Signature: iwc5je41o8knnurxxog88edkdpk3axaq X-Rspamd-Queue-Id: A8A81B00046F X-Rspamd-Server: rspam01 X-HE-Tag: 1626763830-57216 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 19, 2021 at 07:39:47PM +0100, Matthew Wilcox (Oracle) wrote: > The big comment about only using a head page can go away now that > it takes a folio argument. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Darrick J. Wong Looks good, Reviewed-by: Christoph Hellwig (all the iomap work is going to cause heavy clashes with the iomap_iter work, but they should be mostly context, not really functional).