From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4AB6C07E95 for ; Tue, 20 Jul 2021 06:58:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 89F8E6113B for ; Tue, 20 Jul 2021 06:58:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89F8E6113B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3D2E86B0093; Tue, 20 Jul 2021 02:58:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 384616B00DA; Tue, 20 Jul 2021 02:58:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224406B00DC; Tue, 20 Jul 2021 02:58:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id F1B276B0093 for ; Tue, 20 Jul 2021 02:58:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 87F8225F5C for ; Tue, 20 Jul 2021 06:58:22 +0000 (UTC) X-FDA: 78382062444.20.962CF13 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 5461950140B7 for ; Tue, 20 Jul 2021 06:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hkCeS3d3DzM6X5it85/II9q/xV8Q+YyicN3JK3AIkcY=; b=ON9/BWXulkxGtghSvHPjG41NJ3 m+7vnF8DfFO0VTYvtCShHZrh1LEQQ0X+p9w2z6oIaDtBDzV3vbHm957uxwR5ZE+lr78hUE2Q9DhwF xDjmcG7BHs2ui7Vfi1qvmKH8aDGcSQt265VjsSgdO6QFk9bhAF4GUHlKb3jV9p5b2s+nIIgg2VPsQ otbfp/r08dupe4SsjI+FU4U8TCUoGQTWkyOEPoF0MMScouxbQqeFkbi8qVO/ABvFmqDe1wOjAVpo/ 1U8B7/L9V2cNUF2KfHHPbIbiNbQ7m4fQeIb1fiFpX3++7ICSHBWTvGgnH+zFKtALxa7UJ49iJG7rG TLY/JIUg==; Received: from [2001:4bb8:193:7660:5612:5e3c:ba3d:2b3c] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5jgh-007qaT-7d; Tue, 20 Jul 2021 06:57:22 +0000 Date: Tue, 20 Jul 2021 08:57:06 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, "Darrick J . Wong" Subject: Re: [PATCH v15 08/17] iomap: Pass the iomap_page into iomap_set_range_uptodate Message-ID: References: <20210719184001.1750630-1-willy@infradead.org> <20210719184001.1750630-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719184001.1750630-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="ON9/BWXu"; spf=none (imf05.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Stat-Signature: n6gc8ba3rx5whoe3zi7jtjmggr9uf6ft X-Rspamd-Queue-Id: 5461950140B7 X-HE-Tag: 1626764302-344176 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 19, 2021 at 07:39:52PM +0100, Matthew Wilcox (Oracle) wrote: > All but one caller already has the iomap_page, and we can avoid getting > it again. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Darrick J. Wong In general reloading it from a single pointer should be faster than passing an extra argument. What is the rationale here?