From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDBCC07E9B for ; Tue, 20 Jul 2021 10:41:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E878561209 for ; Tue, 20 Jul 2021 10:41:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E878561209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9DBD36B00CB; Tue, 20 Jul 2021 06:41:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B2076B00CC; Tue, 20 Jul 2021 06:41:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 879ED6B00CD; Tue, 20 Jul 2021 06:41:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 5FA486B00CB for ; Tue, 20 Jul 2021 06:41:30 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F09238248047 for ; Tue, 20 Jul 2021 10:41:28 +0000 (UTC) X-FDA: 78382624656.14.F49F1B0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP id A20357001A05 for ; Tue, 20 Jul 2021 10:41:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2A58161165; Tue, 20 Jul 2021 10:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777688; bh=yEsKWSjIDeG5CYGsxYSfoyolXUgGMddSmWQesyZ8Rmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YjTzdqh+lFCzldzGa4JyDiq3MKIfE4yqdhh1SblhWV2Al1xZT8cr6K+caVmTgBMWE knSC7+kc1UPon9e25FX4yL9H6uNmm4hiBbhyEGlBoVE8VUl9hOZxjPpE+QK6HDMO5M bJq+JDUzajyHyV0T4gho2RsuEm6VfQztUZmeX5ihQHk0HzXqbNkJhZ9HYKAdhKN63u FJM3kAX4whqBLcZKjwh29crwhenYPzrmZliew5hJjcaRF0j9uXkE9L/7l+MYSQd2m0 uJBxi4o59Ay5j5rNJi2wGBjMi4bh5CxFKJmpB/6pSTowZ92O5wa7jJgf+avOH+z2A2 ldPpJ77IUcrqg== Date: Tue, 20 Jul 2021 13:41:20 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Zi Yan , Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , Vlastimil Babka , William Kucharski , David Howells Subject: Re: [PATCH v14 007/138] mm: Add folio_put() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-8-willy@infradead.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A20357001A05 X-Stat-Signature: pogxd5tu6woj7mutc798giajyzwwxxdm Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YjTzdqh+; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-HE-Tag: 1626777688-348810 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:34:53AM +0100, Matthew Wilcox (Oracle) wrote: > If we know we have a folio, we can call folio_put() instead of put_page() > and save the overhead of calling compound_head(). Also skips the > devmap checks. > > This commit looks like it should be a no-op, but actually saves 684 bytes > of text with the distro-derived config that I'm testing. Some functions > grow a little while others shrink. I presume the compiler is making > different inlining decisions. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Zi Yan > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: David Howells > --- > include/linux/mm.h | 33 ++++++++++++++++++++++++++++----- > 1 file changed, 28 insertions(+), 5 deletions(-) Acked-by: Mike Rapoport