From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A238C07E95 for ; Tue, 20 Jul 2021 10:44:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4AAE161165 for ; Tue, 20 Jul 2021 10:44:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4AAE161165 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 039E16B00C9; Tue, 20 Jul 2021 06:44:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2AE26B00CA; Tue, 20 Jul 2021 06:44:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF46D6B00CB; Tue, 20 Jul 2021 06:44:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id BCECB6B00C9 for ; Tue, 20 Jul 2021 06:44:52 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5B5FC8248047 for ; Tue, 20 Jul 2021 10:44:51 +0000 (UTC) X-FDA: 78382633182.33.C523328 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP id 153411933 for ; Tue, 20 Jul 2021 10:44:50 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id A91A761208; Tue, 20 Jul 2021 10:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777890; bh=X130X0YVgUCYc69QG5qiLAvITmmN1lXsCRtssf0iGfw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KVApPeMHeRy15Lpbb+D5SHate6j2Rxr3yKHupmiwwCGPpsZL3itxKvpcfjZUQHl42 6iPOZSLA2oJN7wc3w4y8uRYv9VyCb5U+cISizGj61SvpPYRCrKf7tL29zgJbZVen5e Y1WPacVJrk+/vE2m6+54kEuIDmZ8w/ADZSNWx0rb64v4f/gpxMMV8oo4zsKPxA+xdn pYLIQSwfTK28T3cTL/AnjowJ0FTCkq2Jh9QGS5/1eGoOTgpM/E+R9H+sYjt8flell5 EyEQ6WmYfvic28PHXSlDcy1QZ9LJ3hSPeyhBLs4E6Eoju13bp/H3+4Q+VVnwsAFyed cGF6MXcoeZ9HA== Date: Tue, 20 Jul 2021 13:44:42 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , Vlastimil Babka , William Kucharski , David Howells Subject: Re: [PATCH v14 018/138] mm/filemap: Add folio_lock() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-19-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-19-willy@infradead.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 153411933 X-Stat-Signature: d489wnwpyye6e7ayjtiq3wsyjw8z7nd4 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KVApPeMH; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1626777890-532912 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:35:04AM +0100, Matthew Wilcox (Oracle) wrote: > This is like lock_page() but for use by callers who know they have a folio. > Convert __lock_page() to be __folio_lock(). This saves one call to > compound_head() per contended call to lock_page(). > > Saves 455 bytes of text; mostly from improved register allocation and > inlining decisions. __folio_lock is 59 bytes while __lock_page was 79. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: David Howells > --- > include/linux/pagemap.h | 24 +++++++++++++++++++----- > mm/filemap.c | 29 +++++++++++++++-------------- > 2 files changed, 34 insertions(+), 19 deletions(-) Acked-by: Mike Rapoport