From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D78CC07E9B for ; Tue, 20 Jul 2021 10:45:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D24061221 for ; Tue, 20 Jul 2021 10:45:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D24061221 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B83536B00CB; Tue, 20 Jul 2021 06:45:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5A156B00CC; Tue, 20 Jul 2021 06:45:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A232A6B00CD; Tue, 20 Jul 2021 06:45:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 80B3B6B00CB for ; Tue, 20 Jul 2021 06:45:18 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 08FC08248047 for ; Tue, 20 Jul 2021 10:45:17 +0000 (UTC) X-FDA: 78382634274.04.16A3448 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP id BF1DAE00180C for ; Tue, 20 Jul 2021 10:45:16 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 898946120C; Tue, 20 Jul 2021 10:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777916; bh=WQWoajTP6/cp5PISTAolW0ntDNq1tPHYptl5Y2TWjSc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UxGN88tsuN08tzzqyQo2na45Fa8BsYObr5J9ROPhX6NmUIR/HRayXKVe3xHUCUTbm uEUPBk1yhhFnuN74BlM+nkl1U/Ctv0aJAPJ5z1Cahs5Q5Ar7AuXUpFKSMlt43MtqP3 vlG0S5KsdjCuCfG4oPJJmJk6ENeK8D8bjz36AINUZNUtXTwBuuDWjp2IOA2bQ/VItG cVhv2UhGpXTUP0m8Fg0DS8xY1lnz/zAzVFjGIphcAaNYVxptyu6zcBJ949aweGXucO 4nErJUD6ixNhHo9wR6DkhtvH7uxPz3u5hy3a+++rpFAhochfS3PkMLvX/G77bna0Fp NDELd6HayXtIA== Date: Tue, 20 Jul 2021 13:45:07 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , Vlastimil Babka , William Kucharski , David Howells Subject: Re: [PATCH v14 020/138] mm/filemap: Add __folio_lock_async() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-21-willy@infradead.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BF1DAE00180C X-Stat-Signature: jftpq8916yxo53sqh4h79srjfuz48xek Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UxGN88ts; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-HE-Tag: 1626777916-777428 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:35:06AM +0100, Matthew Wilcox (Oracle) wrote: > There aren't any actual callers of lock_page_async(), so remove it. > Convert filemap_update_page() to call __folio_lock_async(). > > __folio_lock_async() is 21 bytes smaller than __lock_page_async(), > but the real savings come from using a folio in filemap_update_page(), > shrinking it from 515 bytes to 404 bytes, saving 110 bytes. The text > shrinks by 132 bytes in total. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: David Howells > --- > fs/io_uring.c | 2 +- > include/linux/pagemap.h | 17 ----------------- > mm/filemap.c | 31 ++++++++++++++++--------------- > 3 files changed, 17 insertions(+), 33 deletions(-) Acked-by: Mike Rapoport