From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91770C07E9B for ; Tue, 20 Jul 2021 10:45:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 47CB861186 for ; Tue, 20 Jul 2021 10:45:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47CB861186 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F05FB6B00A8; Tue, 20 Jul 2021 06:45:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDC8C6B00A9; Tue, 20 Jul 2021 06:45:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA4AE6B00CC; Tue, 20 Jul 2021 06:45:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0188.hostedemail.com [216.40.44.188]) by kanga.kvack.org (Postfix) with ESMTP id B86B96B00A8 for ; Tue, 20 Jul 2021 06:45:30 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5B5C7250C0 for ; Tue, 20 Jul 2021 10:45:29 +0000 (UTC) X-FDA: 78382634778.38.11EFF68 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP id 17849B00046D for ; Tue, 20 Jul 2021 10:45:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id C011561221; Tue, 20 Jul 2021 10:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777928; bh=AoiepgxEITyIJRI5qaMn5CqtGrZnv94SEd8njH1wOHg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XLDKq/7Qy1ARgF8QTIrfXYPTCI2BJ98d3nHYQ/TmYVBNHNO+Ao7hzO15JQspO/B38 hJc4mtlw5HkBLeesli974ynw5Lp8jxuYtPiLMHmU+hpnbk9mO8R2u978fwAyFmKVn4 8V56bCtzQBQ5rD3Xp/Eg7FqBc/FsKLuIImD0Ggk9V4n+qZ60ziinlm4/EFqJfNdoM1 EPEGKo3z/15A0zAIZddR5DbnBoldjVUIAwBiUXCbEQkhMCrt1/d6r73pZgpn2nx1zQ k633OgX8RccMVDxQDxdHM5/dXTaEjpKoUmTL2SkYcmpfP6G1dJDxWIR7kI5buXy/Dv ZXsfiC6Sk9Lkw== Date: Tue, 20 Jul 2021 13:45:21 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , William Kucharski Subject: Re: [PATCH v14 022/138] mm/filemap: Add __folio_lock_or_retry() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-23-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-23-willy@infradead.org> Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="XLDKq/7Q"; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: 4b6zouae73rbszb4in7dwo3tf9dsdcgi X-Rspamd-Queue-Id: 17849B00046D X-HE-Tag: 1626777928-15874 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:35:08AM +0100, Matthew Wilcox (Oracle) wrote: > Convert __lock_page_or_retry() to __folio_lock_or_retry(). This actually > saves 4 bytes in the only caller of lock_page_or_retry() (due to better > register allocation) and saves the 14 byte cost of calling page_folio() > in __folio_lock_or_retry() for a total saving of 18 bytes. Also use > a bool for the return type. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Reviewed-by: William Kucharski > --- > include/linux/pagemap.h | 11 +++++++---- > mm/filemap.c | 20 +++++++++----------- > mm/memory.c | 8 ++++---- > 3 files changed, 20 insertions(+), 19 deletions(-) Acked-by: Mike Rapoport