From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E59C636C8 for ; Tue, 20 Jul 2021 10:46:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8542F611CE for ; Tue, 20 Jul 2021 10:46:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8542F611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 393516B00C9; Tue, 20 Jul 2021 06:46:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 342FB6B00CC; Tue, 20 Jul 2021 06:46:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20B526B00CD; Tue, 20 Jul 2021 06:46:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0069.hostedemail.com [216.40.44.69]) by kanga.kvack.org (Postfix) with ESMTP id F3E856B00C9 for ; Tue, 20 Jul 2021 06:46:06 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 92F0222033 for ; Tue, 20 Jul 2021 10:46:05 +0000 (UTC) X-FDA: 78382636290.29.631E031 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP id 4D52C7001731 for ; Tue, 20 Jul 2021 10:46:05 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 98F9E61186; Tue, 20 Jul 2021 10:46:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777964; bh=/O0vv21Cgn0unUo+i8YkezR6Gk++1U7Fdq0xfVx3pkU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h21+U6b9EbzyiLOtuCFLg8M02NiBEj15fSC7Tt2xkk4vtd3ty3Xi+Fc8bgMg9RXUm 5nE82yW69y8nFnKbjCBpSdkI1hgdh62C37t3U6CbJirYsNL+O/8vTkvpjOOSB0kcK+ EfO0/R8qZraMCF0ItGGgPbjIvhr3DlrOkdBWeMq48czuGG4fY93hOF7citD1av19ab 05tP9cBOn+q3hKSrLBeKo1rk05lQml3eTtzL9pjehbMJ1PL7Ee1QDE3gjwwj0kSAJ8 EQb+c9tM1JxeTdDyZrKsOolArdhqPxMErGQrjVT21JNlkycGZmRcy2nm2L3KbeUoHP j/y6hrrx78j2A== Date: Tue, 20 Jul 2021 13:45:57 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig , "Kirill A . Shutemov" Subject: Re: [PATCH v14 023/138] mm/swap: Add folio_rotate_reclaimable() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-24-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-24-willy@infradead.org> Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h21+U6b9; spf=pass (imf02.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: wwtroz46ox51x4cwsa8qf444erkky7w4 X-Rspamd-Queue-Id: 4D52C7001731 X-HE-Tag: 1626777965-642507 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:35:09AM +0100, Matthew Wilcox (Oracle) wrote: > Convert rotate_reclaimable_page() to folio_rotate_reclaimable(). This > eliminates all five of the calls to compound_head() in this function, > saving 75 bytes at the cost of adding 15 bytes to its one caller, > end_page_writeback(). We also save 36 bytes from pagevec_move_tail_fn() > due to using folios there. Net 96 bytes savings. > > Also move its declaration to mm/internal.h as it's only used by filemap.c. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: Christoph Hellwig > Acked-by: Kirill A. Shutemov > --- > include/linux/swap.h | 1 - > mm/filemap.c | 3 ++- > mm/internal.h | 1 + > mm/page_io.c | 4 ++-- > mm/swap.c | 30 ++++++++++++++++-------------- > 5 files changed, 21 insertions(+), 18 deletions(-) Acked-by: Mike Rapoport