From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1291C07E9B for ; Tue, 20 Jul 2021 10:46:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 544976120C for ; Tue, 20 Jul 2021 10:46:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 544976120C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0859A6B00CA; Tue, 20 Jul 2021 06:46:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0352F6B00CC; Tue, 20 Jul 2021 06:46:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3FCF6B00CD; Tue, 20 Jul 2021 06:46:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id C338E6B00CA for ; Tue, 20 Jul 2021 06:46:19 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 629EB1F358 for ; Tue, 20 Jul 2021 10:46:18 +0000 (UTC) X-FDA: 78382636836.35.76E40ED Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf03.hostedemail.com (Postfix) with ESMTP id 1E2AF30002CC for ; Tue, 20 Jul 2021 10:46:17 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 036CD61208; Tue, 20 Jul 2021 10:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626777977; bh=cVJquzikbqpsZkuMxzOmiVGse7Bj0cQ+8eBMhfsg9Wg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zxx34MNI9MH/cZBKH2d7s8lip8rXG0DY4DX9uI1xHpso2LXpOdc5FOIAVs4/WwIeV rBEJsURmnA6C+xa0CBvQa82WkBaaMJLywO6LRa5K04S4IGCHhpTRs0Z4rv3AH15Jsg 21i5BWrNlncuydrkvOcw/nnEM1hmjLB8MWmC/R+3BOHRs3IN/K6rx/SQJ6adu1XTm6 mvRmBKMv/rmiF9stFbyrkJCSkzowk1xuiqSurCu+W6cdJhyncZtQ1tJhHIm7wUX4NU k2+SCzSCW68+nNAr72WXRHQHz6jnYtpqWYRHHW+azlkx0nIIXRXaaipq8TfWL5+hFX Vh1etDFQMKNqg== Date: Tue, 20 Jul 2021 13:46:09 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , Vlastimil Babka , William Kucharski , David Howells Subject: Re: [PATCH v14 027/138] mm/filemap: Add folio_wait_bit() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-28-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715033704.692967-28-willy@infradead.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1E2AF30002CC X-Stat-Signature: h7hqsntekiak4fr776u1jyis6itkum7n Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Zxx34MNI; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-HE-Tag: 1626777977-185548 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 04:35:13AM +0100, Matthew Wilcox (Oracle) wrote: > Rename wait_on_page_bit() to folio_wait_bit(). We must always wait on > the folio, otherwise we won't be woken up due to the tail page hashing > to a different bucket from the head page. > > This commit shrinks the kernel by 770 bytes, mostly due to moving > the page waitqueue lookup into folio_wait_bit_common(). > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: David Howells > --- > include/linux/pagemap.h | 10 +++--- > mm/filemap.c | 77 +++++++++++++++++++---------------------- > mm/page-writeback.c | 4 +-- > 3 files changed, 43 insertions(+), 48 deletions(-) Acked-by: Mike Rapoport