From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7198DC636C8 for ; Tue, 20 Jul 2021 13:11:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F1AA961106 for ; Tue, 20 Jul 2021 13:11:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1AA961106 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 70ABB6B0011; Tue, 20 Jul 2021 09:11:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6916E6B0036; Tue, 20 Jul 2021 09:11:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50AE66B005D; Tue, 20 Jul 2021 09:11:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 06F8A6B0011 for ; Tue, 20 Jul 2021 09:11:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7DCE31850866F for ; Tue, 20 Jul 2021 13:11:34 +0000 (UTC) X-FDA: 78383002908.29.6C7B91F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id 0470DF000482 for ; Tue, 20 Jul 2021 13:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hgPl5F02pttqsu+FUSnFeMJhzopEmUNSjuPlvxGlBNQ=; b=M6xeEccq4GIeEt99toObAGtega 3m5vXEaKuL0UJFc7tAGqTZZd0Og1h2AmXcr/BLCdSYHDFQQ+ceK9SAwtm4mhWFxtDlpMtrNk6kQtq 3narjx3gwvt6smCi08/VGdQn/hyuOVKK/96yfbhpmT1DUyh7sS2XAUpsD/e4loZnORNGjmGG7wjXq G0ruOtWipKwCrP4s3jcp17w0HyaJCWrYiwi+KfgRX0OrCBHASij/vmXQj7Kl2Wv6ylaAkHkgxUuOS EQBQjX0T+gILeL6j/dEER9Py2kZxiI+hT+kjb7WlRee4qMf0r9+dyT1RyHfUo1jzRxOvlLnk5Iuf7 b/ZhMeKA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5pWL-008850-86; Tue, 20 Jul 2021 13:10:55 +0000 Date: Tue, 20 Jul 2021 14:10:49 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Yu Zhao , Christoph Hellwig , David Howells , "Kirill A . Shutemov" Subject: Re: [PATCH v14 011/138] mm/lru: Add folio LRU functions Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0470DF000482 X-Stat-Signature: 9zq3eyx531fg9ehan68jxycb58duc4ct Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=M6xeEccq; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1626786693-191578 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 20, 2021 at 01:44:10PM +0300, Mike Rapoport wrote: > > /** > > - * page_is_file_lru - should the page be on a file LRU or anon LRU? > > - * @page: the page to test > > + * folio_is_file_lru - should the folio be on a file LRU or anon LRU? > > + * @folio: the folio to test > > * > > - * Returns 1 if @page is a regular filesystem backed page cache page or a lazily > > - * freed anonymous page (e.g. via MADV_FREE). Returns 0 if @page is a normal > > - * anonymous page, a tmpfs page or otherwise ram or swap backed page. Used by > > - * functions that manipulate the LRU lists, to sort a page onto the right LRU > > - * list. > > + * Returns 1 if @folio is a regular filesystem backed page cache folio > > + * or a lazily freed anonymous folio (e.g. via MADV_FREE). Returns 0 if > > + * @folio is a normal anonymous folio, a tmpfs folio or otherwise ram or > > + * swap backed folio. Used by functions that manipulate the LRU lists, > > + * to sort a folio onto the right LRU list. > > * > > * We would like to get this info without a page flag, but the state > > - * needs to survive until the page is last deleted from the LRU, which > > + * needs to survive until the folio is last deleted from the LRU, which > > * could be as far down as __page_cache_release. > > It seems mm_inline.h is not a part of generated API docs, otherwise > kerneldoc would be unhappy about missing Return: description. kernel-doc doesn't warn about that by default. # This check emits a lot of warnings at the moment, because many # functions don't have a 'Return' doc section. So until the number # of warnings goes sufficiently down, the check is only performed in # verbose mode. # TODO: always perform the check. if ($verbose && !$noret) { check_return_section($file, $declaration_name, $return_type); }