From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 848EDC07E95 for ; Tue, 20 Jul 2021 17:18:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C9F2E610FB for ; Tue, 20 Jul 2021 17:18:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9F2E610FB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 29E996B0011; Tue, 20 Jul 2021 13:18:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 275446B0036; Tue, 20 Jul 2021 13:18:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13E286B005D; Tue, 20 Jul 2021 13:18:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id E480B6B0011 for ; Tue, 20 Jul 2021 13:18:35 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 73B95276F5 for ; Tue, 20 Jul 2021 17:18:34 +0000 (UTC) X-FDA: 78383625348.32.BF430D6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id E6BAD2001502 for ; Tue, 20 Jul 2021 17:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nIUPbWmLSj16v4fdAmjxUh4nxogfx1bpU0hHVWTHTvI=; b=nAMqbSKWqbj/Ac8oc6FDFmgton RWU7nDnH8HrY85pFnG7w+Znd8kqgpgYH6kGrc0ZS0U4Rj3cgtOVkZ9CQVcSB3AvQJmFeaBpDg+AHQ 3h17EK9hTAwPtE9UQjVBjT9mYQ+kKPofbajFnmisOvdG3HmquACGcZSlEszqrCdkAGjDlyt+lkrQI LluCGBk2OL/UMvMOhPbeJDLHHibCxk6RvoNSe81nNjIfrVuvZizcHHWE5F9fKbAYiLEXwW3tPSiYx WWVglYjmfJGXd1ANfpypqnnW2wcjiJp4xM99heruNQkZJtVfWHzadyV2PUALLWwC3WAXgisP+MSTT i9ru9xuA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5tNl-008LUQ-99; Tue, 20 Jul 2021 17:18:17 +0000 Date: Tue, 20 Jul 2021 18:18:13 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 000/138] Memory folios Message-ID: References: <20210715033704.692967-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=nAMqbSKW; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: 1q3gfqjowh6dtcu5owi96d9fc311gcq8 X-Rspamd-Queue-Id: E6BAD2001502 X-Rspamd-Server: rspam01 X-HE-Tag: 1626801513-138737 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 20, 2021 at 06:35:50PM +0300, Mike Rapoport wrote: > On Tue, Jul 20, 2021 at 04:23:29PM +0100, Matthew Wilcox wrote: > > Which patch did you go up to for that? If you're going past patch 50 or > > so, then you're starting to add functionality (ie support for arbitrary > > order pages), so a certain amount of extra code size might be expected. > > I measured 6KB at patch 32 or so, then between patch 32 & 50 was pretty > > much a wash. > > I've used folio_14 tag: > > commit 480552d0322d855d146c0fa6fdf1e89ca8569037 (HEAD, tag: folio_14) > Author: Matthew Wilcox (Oracle) > Date: Wed Feb 5 11:27:01 2020 -0500 > > mm/readahead: Add multi-page folio readahead Probably worth trying the for-next tag instead to get a meaningful comparison of how much using folios saves over pages. I don't want to give the impression that this is all that can be saved by switching to folios. There are still hundreds of places that call PageFoo(), SetPageFoo(), ClearPageFoo(), put_page(), get_page(), lock_page() and so on. There's probably another 20KB of code that can be removed that way.