From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CF6C4338F for ; Sat, 7 Aug 2021 10:32:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6D54610FB for ; Sat, 7 Aug 2021 10:32:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6D54610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1C6DA6B0081; Sat, 7 Aug 2021 06:32:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 178268D0005; Sat, 7 Aug 2021 06:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 065F88D0002; Sat, 7 Aug 2021 06:32:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id DE5EA6B0081 for ; Sat, 7 Aug 2021 06:32:10 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 734C6181B0487 for ; Sat, 7 Aug 2021 10:32:10 +0000 (UTC) X-FDA: 78447919620.09.16B2BB5 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP id 2145E900888E for ; Sat, 7 Aug 2021 10:32:10 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 18487610FC; Sat, 7 Aug 2021 10:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628332329; bh=q0JbSC4fX4Crhi1HrqSNaN67de1iCkzSUaCVowYclWc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fsKTwecZe161gdAJQQnyQfzWRCWKtSI17t3EW2r28Gew517Y3JIG85wSBnFhNDI3r yGBQpyi7/ih3s7Q+f6DT0xIKDfvkzFbjVbBY1WK/mbWYGJRxJlsh1y9LX+FbBh46eV JYiIs0+AXJ/mjkz1PkHvHD7P5i2Wc3h8ZZeelre82v6V3CC02Rqs7WmF2gIZ/IVtuw zxAknc/fQcFuL0DLvtfzYQiaYcoRw1xmG91FwgwYzfzPa2zb9zFs777Tla0VmvJ1WT cXAViWgi2TVIv/pUNGCJZmG8JasYImcSxG/g01QJcscEsR0FzAKD8eTLbclBkET1uh xGUmkqO6QNU9Q== Date: Sat, 7 Aug 2021 13:32:00 +0300 From: Mike Rapoport To: Zi Yan Cc: David Hildenbrand , linux-mm@kvack.org, Matthew Wilcox , Vlastimil Babka , "Kirill A . Shutemov" , Mike Kravetz , Michal Hocko , John Hubbard , linux-kernel@vger.kernel.org, Oscar Salvador , Ying Chen , Feng Zhou , linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH 08/15] fs: proc: use PAGES_PER_SECTION for page offline checking period. Message-ID: References: <20210805190253.2795604-1-zi.yan@sent.com> <20210805190253.2795604-9-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210805190253.2795604-9-zi.yan@sent.com> Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fsKTwecZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: 85u4oh3mnn1yb8xxo7jhnufdd35ch965 X-Rspamd-Queue-Id: 2145E900888E X-Rspamd-Server: rspam01 X-HE-Tag: 1628332330-570159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 05, 2021 at 03:02:46PM -0400, Zi Yan wrote: > From: Zi Yan > > It keeps the existing behavior after MAX_ORDER is increased beyond > a section size. > > Signed-off-by: Zi Yan > Cc: Mike Rapoport > Cc: David Hildenbrand > Cc: Oscar Salvador > Cc: Ying Chen > Cc: Feng Zhou > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > fs/proc/kcore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c > index 3f148759a5fd..77b7ba48fb44 100644 > --- a/fs/proc/kcore.c > +++ b/fs/proc/kcore.c > @@ -486,7 +486,7 @@ read_kcore(struct file *file, char __user *buffer, size_t buflen, loff_t *fpos) > } > } > > - if (page_offline_frozen++ % MAX_ORDER_NR_PAGES == 0) { > + if (page_offline_frozen++ % PAGES_PER_SECTION == 0) { The behavior changes here. E.g. with default configuration on x86 instead of cond_resched() every 2M we get cond_resched() every 128M. I'm not saying it's wrong but at least it deserves an explanation why. > page_offline_thaw(); > cond_resched(); > page_offline_freeze(); > -- > 2.30.2 > -- Sincerely yours, Mike.