linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Chen Wandun <chenwandun@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com,
	weiyongjun1@huawei.com
Subject: Re: [PATCH] mm/vmalloc: add missing __GFP_HIGHMEM flag for vmalloc
Date: Tue, 27 Jul 2021 18:30:28 +0100	[thread overview]
Message-ID: <YQBCtHv1qD4Pinw/@casper.infradead.org> (raw)
In-Reply-To: <f064b046-8831-2aa9-2234-63e867e28dc1@huawei.com>

On Mon, Jul 26, 2021 at 12:05:44PM +0800, Chen Wandun wrote:
> 在 2021/7/26 11:25, Matthew Wilcox 写道:
> > On Mon, Jul 26, 2021 at 11:23:33AM +0800, Chen Wandun wrote:
> > > struct page array can also be allocated in highmem during vmalloc,
> > > that will ease the low memory stress in 32bit system.
> > Huh?  Where does it get kmapped in order to access it?

(i misread your patch, apologies)

> The struct page array contain numbers of pointer of struct page, it is used to save
> 
> pages that allocated for vmalloc mapping in vmap_pages_range, it does't need to kmap.
> 
> 
> The main idea of this patch is come from:
> 
> https://lore.kernel.org/lkml/20170307141020.29107-1-mhocko@kernel.org/

you've misunderstood that patch.  think about it:

static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
                                 pgprot_t prot, unsigned int page_shift,
                                 int node)
{
	const gfp_t nested_gfp = (gfp_mask & GFP_RECLAIM_MASK) | __GFP_ZERO;
(now nested_gfp has neither DMA nor DMA32 set)

        gfp_mask |= __GFP_NOWARN;
        if (!(gfp_mask & (GFP_DMA | GFP_DMA32)))
                gfp_mask |= __GFP_HIGHMEM;
(we set HIGHMEM if DMA and DMA32 are both not set)

                area->pages = __vmalloc_node(array_size, 1, nested_gfp, node,
                                        area->caller);
(we don't need to set HIGHMEM here because it will be set for us in
the second call to __vmalloc_area_node)


  reply	other threads:[~2021-07-27 17:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26  3:23 [PATCH] mm/vmalloc: add missing __GFP_HIGHMEM flag for vmalloc Chen Wandun
2021-07-26  3:25 ` Matthew Wilcox
2021-07-26  4:05   ` Chen Wandun
2021-07-27 17:30     ` Matthew Wilcox [this message]
2021-07-28  1:13       ` Chen Wandun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQBCtHv1qD4Pinw/@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=chenwandun@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).