From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9490C4338F for ; Fri, 30 Jul 2021 06:45:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 65CD961008 for ; Fri, 30 Jul 2021 06:45:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 65CD961008 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0EA086B005D; Fri, 30 Jul 2021 02:45:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 099CD6B006C; Fri, 30 Jul 2021 02:45:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF1A56B0070; Fri, 30 Jul 2021 02:45:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id DB29C6B005D for ; Fri, 30 Jul 2021 02:45:14 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7CDB38249980 for ; Fri, 30 Jul 2021 06:45:14 +0000 (UTC) X-FDA: 78418317348.08.8AFADD8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf17.hostedemail.com (Postfix) with ESMTP id 0E279F00348F for ; Fri, 30 Jul 2021 06:45:13 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 1187F1FDB1; Fri, 30 Jul 2021 06:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1627627513; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WGSyxiu3mrpSdkjXI3OCcCS7NGg99qcrN67xRlpt+bI=; b=IWh87TmkxKW563aoJcyB30+0gBdeVgoR4oJhyn/AYZvZFSpSJXs26QYdLwE5pjm4gdPxBa hzHiMc9UMDaYVP718QqWr/dn9w7IizFkFnIHAKFFvOfwzZNUDRrGAKFN8A0EdbAuy5/vSv JbSeOr284ji3GsEFA12JxCn9klheDSo= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id C9291A3B88; Fri, 30 Jul 2021 06:45:12 +0000 (UTC) Date: Fri, 30 Jul 2021 08:45:12 +0200 From: Michal Hocko To: Miaohe Lin Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com, willy@infradead.org, alexs@kernel.org, richard.weiyang@gmail.com, songmuchun@bytedance.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 1/5] mm, memcg: remove unused functions Message-ID: References: <20210729125755.16871-1-linmiaohe@huawei.com> <20210729125755.16871-2-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729125755.16871-2-linmiaohe@huawei.com> Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=IWh87Tmk; spf=pass (imf17.hostedemail.com: domain of mhocko@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0E279F00348F X-Stat-Signature: z9jpmrkntcutqqgbsyn6bdk8qoixh97n X-HE-Tag: 1627627513-915159 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 29-07-21 20:57:51, Miaohe Lin wrote: > Since commit 2d146aa3aa84 ("mm: memcontrol: switch to rstat"), last user > of memcg_stat_item_in_bytes() is gone. And since commit fa40d1ee9f15 ("mm: > vmscan: memcontrol: remove mem_cgroup_select_victim_node()"), only the > declaration of mem_cgroup_select_victim_node() is remained here. Remove > them. > > Signed-off-by: Miaohe Lin Acked-by: Michal Hocko > --- > include/linux/memcontrol.h | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 7028d8e4a3d7..04437504444f 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -606,13 +606,6 @@ static inline bool PageMemcgKmem(struct page *page) > return folio_memcg_kmem(page_folio(page)); > } > > -static __always_inline bool memcg_stat_item_in_bytes(int idx) > -{ > - if (idx == MEMCG_PERCPU_B) > - return true; > - return vmstat_item_in_bytes(idx); > -} > - > static inline bool mem_cgroup_is_root(struct mem_cgroup *memcg) > { > return (memcg == root_mem_cgroup); > @@ -916,11 +909,6 @@ static inline bool mem_cgroup_online(struct mem_cgroup *memcg) > return !!(memcg->css.flags & CSS_ONLINE); > } > > -/* > - * For memory reclaim. > - */ > -int mem_cgroup_select_victim_node(struct mem_cgroup *memcg); > - > void mem_cgroup_update_lru_size(struct lruvec *lruvec, enum lru_list lru, > int zid, int nr_pages); > > -- > 2.23.0 -- Michal Hocko SUSE Labs