From: Michal Hocko <email@example.com> To: Aaron Tomlin <firstname.lastname@example.org> Cc: email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: Re: [PATCH v3] mm/oom_kill: show oom eligibility when displaying the current memory state of all tasks Date: Mon, 2 Aug 2021 08:34:24 +0200 [thread overview] Message-ID: <YQeR8FTlzrojIbSo@dhcp22.suse.cz> (raw) In-Reply-To: <firstname.lastname@example.org> On Fri 30-07-21 17:20:02, Aaron Tomlin wrote: > Changes since v2: > - Use single character (e.g. 'R' for MMF_OOM_SKIP) as suggested > by Tetsuo Handa <email@example.com> > - Add new header to oom_dump_tasks documentation > - Provide further justification > > > The output generated by dump_tasks() can be helpful to determine why > there was an OOM condition and which rogue task potentially caused it. > Please note that this is only provided when sysctl oom_dump_tasks is > enabled. > > At the present time, when showing potential OOM victims, we do not > exclude any task that are not OOM eligible e.g. Well, this is not precise. We do exclude ineligible. Consider tasks that are outside of the OOM domain for example. You are right that we are not excluding all of them though. > those that have > MMF_OOM_SKIP set; it is possible that the last OOM killable victim was > already OOM killed, yet the OOM reaper failed to reclaim memory and set > MMF_OOM_SKIP. This can be confusing (or perhaps even be misleading) to the > viewer. Now, we already unconditionally display a task's oom_score_adj_min > value that can be set to OOM_SCORE_ADJ_MIN which is indicative of an > "unkillable" task. > > This patch provides a clear indication with regard to the OOM ineligibility > (and why) of each displayed task with the addition of a new column namely > "oom_skipped". An example is provided below: > > [ 5084.524970] [ pid ] uid tgid total_vm rss pgtables_bytes swapents oom_score_adj oom_skipped name > [ 5084.526397]  0 660417 35869 683 167936 0 -1000 M conmon > [ 5084.526400]  0 660452 175834 472 86016 0 -998 pod > [ 5084.527460]  0 752415 35869 650 172032 0 -1000 M conmon > [ 5084.527462]  1001050000 752575 184205 11158 700416 0 999 npm > [ 5084.527467]  1001050000 753606 183380 46843 2134016 0 999 node > [ 5084.527581] Memory cgroup out of memory: Killed process 753606 (node) total-vm:733520kB, anon-rss:161228kB, file-rss:26144kB, shmem-rss:0kB, UID:1001050000 > > So, a single character 'M' is for OOM_SCORE_ADJ_MIN, 'R' MMF_OOM_SKIP and > 'V' for in_vfork(). I have to say I dislike this for two reasons. First and foremost it makes parsing unnecessarily more complex. Now you have a potentially an empty column to special case. Secondly MMF_OOM_SKIP is an internal state that shouldn't really leak to userspace IMO. in_vfork is a racy check and M is already expressed via oom_score_adj so it duplicates an existing information. If you really want/need to make any change here then I would propose to either add E(eligible)/I(ligible) column without any specifics or consistently skip over all tasks which are not eligible. > 2.31.1 -- Michal Hocko SUSE Labs
next prev parent reply other threads:[~2021-08-02 6:34 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-30 16:20 Aaron Tomlin 2021-08-01 20:01 ` Andrew Morton 2021-08-02 3:49 ` David Rientjes 2021-08-02 14:50 ` Aaron Tomlin 2021-08-02 6:34 ` Michal Hocko [this message] 2021-08-02 15:12 ` Aaron Tomlin 2021-08-03 7:05 ` Michal Hocko 2021-08-03 10:32 ` Aaron Tomlin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YQeR8FTlzrojIbSo@dhcp22.suse.cz \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v3] mm/oom_kill: show oom eligibility when displaying the current memory state of all tasks' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).