From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F73C4320E for ; Tue, 3 Aug 2021 07:58:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F27D160F8F for ; Tue, 3 Aug 2021 07:58:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F27D160F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 973A58D0001; Tue, 3 Aug 2021 03:58:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 923DC6B0036; Tue, 3 Aug 2021 03:58:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8123D8D0001; Tue, 3 Aug 2021 03:58:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 66B856B0033 for ; Tue, 3 Aug 2021 03:58:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1542F8249980 for ; Tue, 3 Aug 2021 07:58:49 +0000 (UTC) X-FDA: 78433017978.10.CDE629F Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf10.hostedemail.com (Postfix) with ESMTP id A20A1600B66E for ; Tue, 3 Aug 2021 07:58:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id EE40360F01; Tue, 3 Aug 2021 07:58:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627977527; bh=xrL0L5sjmEbvAkIaM5DGTisQzBhF+YdUH3ou+1qqyG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sRBVCHEHNAVwAvlSuUBEhFfD7chxFF0uhc/a362qNsf4FIq3FHkg6HTjznR5/prww l5Cg2J4mtQRpp43pjt0z7A9cOibVYYUJBbNRbtKEGa4APmlJRa9F6VIFuKQsV9nrwZ DlwsCsWmBI6nLgSSMxWaiOj9mPwVdCCj9fKlavEn4FbMvVXIqUxtGrqmBGZC2KpZU5 F9r/V6mgrvxF4sUMCpPZzOv+NmFOUsiNLSoHS5bAO5Vf9FKFK7tsoWnBhpdmgicQUG uWCwgU4ZgGTItiWhvVGDjB3+cCUrtzRmuRHAPLJdh3/Pti7VMRm3JLHyvOqI/dFQ8O eLN3UYYYUGM3A== Date: Tue, 3 Aug 2021 10:58:42 +0300 From: Mike Rapoport To: Joe Perches Cc: Andrew Morton , Michal Simek , Mike Rapoport , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 4/4] memblock: stop poisoning raw allocations Message-ID: References: <20210714123739.16493-1-rppt@kernel.org> <20210714123739.16493-5-rppt@kernel.org> <72be13936ca341897d2fd7c65fb4345a8467c571.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <72be13936ca341897d2fd7c65fb4345a8467c571.camel@perches.com> Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sRBVCHEH; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Stat-Signature: 54myipxj4s7oadd56qb1msjdthijtuxt X-Rspamd-Queue-Id: A20A1600B66E X-Rspamd-Server: rspam01 X-HE-Tag: 1627977528-495146 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 31, 2021 at 10:13:04AM -0700, Joe Perches wrote: > On Wed, 2021-07-14 at 15:37 +0300, Mike Rapoport wrote: > > From: Mike Rapoport > >=20 > > Functions memblock_alloc_exact_nid_raw() and memblock_alloc_try_nid_r= aw() > > are intended for early memory allocation without overhead of zeroing = the > > allocated memory. Since these functions were used to allocate the mem= ory > > map, they have ended up with addition of a call to page_init_poison()= that > > poisoned the allocated memory when CONFIG_PAGE_POISON was set. > >=20 > > Since the memory map is allocated using a dedicated memmep_alloc() fu= nction > > that takes care of the poisoning, remove page poisoning from the > > memblock_alloc_*_raw() functions. > [] > > diff --git a/mm/memblock.c b/mm/memblock.c > [] > > @@ -1490,18 +1490,12 @@ void * __init memblock_alloc_exact_nid_raw( > > =A0 phys_addr_t min_addr, phys_addr_t max_addr, > > =A0 int nid) > > =A0{ > > - void *ptr; > > - > > =A0 memblock_dbg("%s: %llu bytes align=3D0x%llx nid=3D%d from=3D%pa m= ax_addr=3D%pa %pS\n", > > =A0 __func__, (u64)size, (u64)align, nid, &min_addr, > > =A0 &max_addr, (void *)_RET_IP_); >=20 > unassociated trivia: >=20 > casting _RET_IP_ back to void * seems odd as the define is > include/linux/kernel.h:#define _RET_IP_ (unsigned long)__builti= n_return_address(0) >=20 > It's probably easier to understand as just __builtin_return_address(0) Maybe, but I'm not sure it's worth the churn. =20 > > @@ -1528,18 +1522,12 @@ void * __init memblock_alloc_try_nid_raw( > > =A0 phys_addr_t min_addr, phys_addr_t max_addr, > > =A0 int nid) > > =A0{ > > - void *ptr; > > - > > =A0 memblock_dbg("%s: %llu bytes align=3D0x%llx nid=3D%d from=3D%pa m= ax_addr=3D%pa %pS\n", > > =A0 __func__, (u64)size, (u64)align, nid, &min_addr, > > =A0 &max_addr, (void *)_RET_IP_); >=20 > here too >=20 --=20 Sincerely yours, Mike.