From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDC5C432BE for ; Fri, 13 Aug 2021 18:57:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2ADA861038 for ; Fri, 13 Aug 2021 18:57:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2ADA861038 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 820158D0002; Fri, 13 Aug 2021 14:57:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D0AD8D0001; Fri, 13 Aug 2021 14:57:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E6368D0002; Fri, 13 Aug 2021 14:57:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 520408D0001 for ; Fri, 13 Aug 2021 14:57:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D93AB18298B0C for ; Fri, 13 Aug 2021 18:57:41 +0000 (UTC) X-FDA: 78470966322.23.D5F53DA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 5F481400209D for ; Fri, 13 Aug 2021 18:57:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=n0UYFCDfn/6EPWQxCxZcMRZGDBC1ig7t4FOClsfmIzs=; b=rW+90qbnrmWgb2k22pBJY1LrTl jzfGsbj5b5h/mRwDC/MoMZR4VlwW/j4l/xA93697kYfOtilnQbg1A8oCNMl+DwNUoE+f2S8ilfDTM c+4Vf9+pKxgClznbZg+rZbIkuzaSiE1umQI9mL4cSmVXdQCtDCkni9eJ+DPUBDqa4nq73fmFfPMM4 n3TzbOD58Env3CuCXuPttnqaJwk9CfAtEtCz5/sT7Q1FIkfQh7LanDbrgSqLd1n7cGzkdDXNxtE/4 fqZmvsDdp05jgrn3NawXLYWDrECWlHpXwuIJsGA8FZi9srrakhVtLo80NVIr1ZytvbJn2H6LdH3cJ 3sNjNXHA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEcMG-00Fz7Y-L1; Fri, 13 Aug 2021 18:56:51 +0000 Date: Fri, 13 Aug 2021 19:56:44 +0100 From: Matthew Wilcox To: David Howells Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Michal Hocko , Johannes Weiner , Christoph Hellwig Subject: Re: [PATCH v14 035/138] mm/memcg: Use the node id in mem_cgroup_update_tree() Message-ID: References: <20210715033704.692967-36-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> <1809568.1628626012@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1809568.1628626012@warthog.procyon.org.uk> Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rW+90qbn; dmarc=none; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: dagqudqt8kggnsm63yfrfxh36hba8y7s X-Rspamd-Queue-Id: 5F481400209D X-Rspamd-Server: rspam05 X-HE-Tag: 1628881061-99342 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 10, 2021 at 09:06:52PM +0100, David Howells wrote: > Matthew Wilcox (Oracle) wrote: > > > By using the node id in mem_cgroup_update_tree(), we can delete > > soft_limit_tree_from_page() and mem_cgroup_page_nodeinfo(). Saves 42 > > bytes of kernel text on my config. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > Acked-by: Michal Hocko > > Acked-by: Johannes Weiner > > Reviewed-by: Christoph Hellwig > > Reviewed-by: David Howells > > Though I wonder if: > > > - mz = mem_cgroup_page_nodeinfo(memcg, page); > > + mz = memcg->nodeinfo[nid]; > > should still have some sort of wrapper function. I was asked to remove the wrapper function as it didn't provide enough utility to warrant the indirection.