From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A4B4C4338F for ; Sat, 14 Aug 2021 04:06:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B729360E76 for ; Sat, 14 Aug 2021 04:06:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B729360E76 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1BF246B006C; Sat, 14 Aug 2021 00:06:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16EC76B0071; Sat, 14 Aug 2021 00:06:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0859D8D0001; Sat, 14 Aug 2021 00:06:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id E64046B006C for ; Sat, 14 Aug 2021 00:06:20 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 958D418F4A for ; Sat, 14 Aug 2021 04:06:20 +0000 (UTC) X-FDA: 78472348920.01.F784945 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id ED314D019E64 for ; Sat, 14 Aug 2021 04:06:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OzjG0eOWjSaTVzdwrlhA4xUXM2AfVf8c6T5tJbSz1go=; b=GMiVEV1pzyYY/voBVEbEdW1p52 Adwfq2c++/p1q6s7sYbZIB4lPhSO6EsiSYSVWWPKqWfGyfrQp5smbanCUzny8pnpGkA3QDiekO/pW 3NReojatqkPbUVwSQCM3ZsWP25Bhn0l5SprZRHWP5B+fnvD2iAredMtPzWEsP4RYda4/WM1oaNDvl aVD6eISnjsEaYsMaVxUUCCjTVqTnw/yvPq0cYw6TCSZHENEB3rlP1M1Q80nJVWCQNlsvqKqnxOrvy s7y6aQJglqgqgGVO2GYxukH1CQ7NzOYmIbyh/MgwxMCntHb/A63Nj+ozRwYlrajhauphJJfjTLjw0 qPKNw+8Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEkvY-00GMni-8p; Sat, 14 Aug 2021 04:05:53 +0000 Date: Sat, 14 Aug 2021 05:05:44 +0100 From: Matthew Wilcox To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 050/138] mm/workingset: Convert workingset_activation to take a folio Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-51-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GMiVEV1p; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: z4ays33qca9uf4ajaz8938oyrecyigej X-Rspamd-Queue-Id: ED314D019E64 X-Rspamd-Server: rspam05 X-HE-Tag: 1628913979-39799 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 21, 2021 at 12:51:57PM +0300, Mike Rapoport wrote: > > /* > > - * page_memcg_rcu - locklessly get the memory cgroup associated with a page > > - * @page: a pointer to the page struct > > + * folio_memcg_rcu - Locklessly get the memory cgroup associated with a folio. > > + * @folio: Pointer to the folio. > > * > > - * Returns a pointer to the memory cgroup associated with the page, > > - * or NULL. This function assumes that the page is known to have a > > + * Returns a pointer to the memory cgroup associated with the folio, > > + * or NULL. This function assumes that the folio is known to have a > > * proper memory cgroup pointer. It's not safe to call this function > > - * against some type of pages, e.g. slab pages or ex-slab pages. > > + * against some type of folios, e.g. slab folios or ex-slab folios. > > Maybe > > - * Returns a pointer to the memory cgroup associated with the page, > - * or NULL. This function assumes that the page is known to have a > + * This function assumes that the folio is known to have a > * proper memory cgroup pointer. It's not safe to call this function > - * against some type of pages, e.g. slab pages or ex-slab pages. > + * against some type of folios, e.g. slab folios or ex-slab folios. > + * > + * Return: a pointer to the memory cgroup associated with the folio, > + * or NULL. I substantially included this change a few days ago and forgot to reply to this email; sorry. It now reads: /** * folio_memcg_rcu - Locklessly get the memory cgroup associated with a folio. * @folio: Pointer to the folio. * * This function assumes that the folio is known to have a * proper memory cgroup pointer. It's not safe to call this function * against some type of folios, e.g. slab folios or ex-slab folios. * * Return: A pointer to the memory cgroup associated with the folio, * or NULL. */