From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2280AC4338F for ; Sat, 14 Aug 2021 16:52:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A08560FC1 for ; Sat, 14 Aug 2021 16:52:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9A08560FC1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D56378D0001; Sat, 14 Aug 2021 12:52:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D070D6B0071; Sat, 14 Aug 2021 12:52:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF4ED8D0001; Sat, 14 Aug 2021 12:52:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id AA20F6B006C for ; Sat, 14 Aug 2021 12:52:06 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2FC568249980 for ; Sat, 14 Aug 2021 16:52:06 +0000 (UTC) X-FDA: 78474278652.19.8134642 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id CA3E1801AB16 for ; Sat, 14 Aug 2021 16:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=THZ//hV3fEyfAA4zhklKtKpMz1OFaHnMmtlB1qWq1hg=; b=KedV6pi3ZXiTo5WIk8Uo2beK0N UcDULdF2vZ9BxASpNSR7UaI3c3iU/fWiKCtM21zMX/YvS+njS/e7R7SFyUR7qS6rWQx7yWwOgru57 YHUe/u6pKQCQNFOnyiy7OIxhdCbQOLf6SbXAkG0qb1TD/mn5A4jclTnUweo/sNgHczjL3GEVzIIXp BYFLhjat+sF4Cux8JG401ykGk9DojGJgPQLsQvUmQsP43U+/lTWzkpL1V4Z9O6sjMAe2Fn5aO0Bw4 llNeag6pF+9c07EG4MLzC00Sr6PDfMHl+C5ANf1ZX6DJs551Qxec74qm1Xg1l6zSHTSYcbuJ+QNuj aUEdqxfQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEwsX-00GrRQ-Rk; Sat, 14 Aug 2021 16:51:33 +0000 Date: Sat, 14 Aug 2021 17:51:25 +0100 From: Matthew Wilcox To: David Howells Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 052/138] mm: Add folio_raw_mapping() Message-ID: References: <20210715033704.692967-53-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> <1811270.1628628133@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1811270.1628628133@warthog.procyon.org.uk> Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KedV6pi3; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 9xgdap67q6m6n97fz79y9qmk4ptq7hw7 X-Rspamd-Queue-Id: CA3E1801AB16 X-Rspamd-Server: rspam05 X-HE-Tag: 1628959925-635633 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 10, 2021 at 09:42:13PM +0100, David Howells wrote: > Matthew Wilcox (Oracle) wrote: > > > Convert __page_rmapping to folio_raw_mapping and move it to mm/internal.h. > > It's only a couple of instructions (load and mask), so it's definitely > > going to be cheaper to inline it than call it. Leave page_rmapping > > out of line. > > > > Signed-off-by: Matthew Wilcox (Oracle) > > I assume you're going to call it from another source file at some point, > otherwise this is unnecessary. Yes, it gets called from mm/ksm.c in a later patch in this series. __page_rmapping() assumes it's being passed a head page and folio_raw_mapping() asserts that. Eventually, page_rmapping() can go away (and maybe it should have been moved to folio-compat.c), but I'm not inclined to do that now. > Apart from that, > > Reviewed-by: David Howells >