From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC7E8C4338F for ; Sat, 14 Aug 2021 17:06:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4F23160EB2 for ; Sat, 14 Aug 2021 17:06:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4F23160EB2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 902BB6B006C; Sat, 14 Aug 2021 13:06:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AFE88D0001; Sat, 14 Aug 2021 13:06:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5646B0072; Sat, 14 Aug 2021 13:06:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id 60B8F6B006C for ; Sat, 14 Aug 2021 13:06:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0B4E318280004 for ; Sat, 14 Aug 2021 17:06:48 +0000 (UTC) X-FDA: 78474315696.03.85AE541 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id BCF881000F59 for ; Sat, 14 Aug 2021 17:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N9Yv2av3cpyv3lJbvKZNeQlU7TaQP8VpMldoCKFJq8k=; b=hQ+oYO7a1shonLjP7Cn0NzXSqZ vv+8E0DmbARYhOfI5154UkFS3yh+j7O90EJYchLMpF7V1uNiEfBFr22KCiT3iCuXynwPGcrR6LTZh ZyPdEFwZjxwNfr4wMXOXpPCcDx/HjQCwrL+eALaLWdzcADJuqFvQx6tt9CVlDv+LTf1VXCLgmkp09 XlmaS4LDT2pM2sprqtS1+XoDNCLaM78OeJhGgEQ15SHBGGM8Vqe26RqQPvothSiQfuNSEQoHrvz5B snbAg51ztzmkLuV37jQGJoNXgPX5Rl8VY267ldcQdkNt6N3Rc6eWkob9lwD+EbDgMdxDmsYW6jlnR sdZQnpvQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEx6l-00GrzN-7C; Sat, 14 Aug 2021 17:06:15 +0000 Date: Sat, 14 Aug 2021 18:06:07 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 052/138] mm: Add folio_raw_mapping() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-53-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=hQ+oYO7a; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BCF881000F59 X-Stat-Signature: c6crnrcw37hp3mis144tbweuucwcbztn X-HE-Tag: 1628960807-352976 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 11, 2021 at 03:59:06PM +0200, Vlastimil Babka wrote: > On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > > Convert __page_rmapping to folio_raw_mapping and move it to mm/internal.h. > > It's only a couple of instructions (load and mask), so it's definitely > > going to be cheaper to inline it than call it. Leave page_rmapping > > out of line. > > Maybe mention the page_anon_vma() in changelog too? Convert __page_rmapping to folio_raw_mapping and move it to mm/internal.h. It's only a couple of instructions (load and mask), so it's definitely going to be cheaper to inline it than call it. Leave page_rmapping out of line. Change page_anon_vma() to not call folio_raw_mapping() -- it's more efficient to do the subtraction than the mask.