From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE37BC432BE for ; Sun, 15 Aug 2021 10:54:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2311A60E78 for ; Sun, 15 Aug 2021 10:54:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2311A60E78 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B2C0C6B006C; Sun, 15 Aug 2021 06:54:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADC886B0071; Sun, 15 Aug 2021 06:54:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CBF96B0072; Sun, 15 Aug 2021 06:54:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id 83FD36B006C for ; Sun, 15 Aug 2021 06:54:20 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 22B8C8249980 for ; Sun, 15 Aug 2021 10:54:20 +0000 (UTC) X-FDA: 78477005880.06.F4C5F7C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id CCE5C900186D for ; Sun, 15 Aug 2021 10:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BPpQnC+2U721SzsLqmKDnAhfH5B8tesCsHy+xocU1F0=; b=uPCnuqIVC7EMq+U9nIXh1InckD RvEC4JUXgEZRkbPhnQjM475xx+aRmSPe1qS4HuYil7vHWaR5WuBJYGKrtztsBr/jCSb8QyqC3yzTu 0nmS8ZEDGTSkpCehVEs1HdrfyZHJ8vIOSg2NDcaA1Y0JW96c3ggaYwnaesE7lYjAmbAMDR+MBim5G TIJciqqzbed/O4pXdzYDbF37vq7PAisuhun+4kbNF0A7hshjyX//SeGQ1fze/L4PMYMGA2wBQzOoc /yD8B2hPI98JIdjz0RRxZDtrEF330DjoPauoosVisalNpp8Fjvl3hR3WCySPAwdYSmIq3hVhG9QtZ jIq6IU9Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFDmB-0005BS-Pt; Sun, 15 Aug 2021 10:54:06 +0000 Date: Sun, 15 Aug 2021 11:53:59 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 072/138] mm/writeback: Add folio_account_cleaned() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-73-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uPCnuqIV; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-Stat-Signature: 4yh9bnjy6as3nizcojcs8rxpf8qz1f8i X-Rspamd-Queue-Id: CCE5C900186D X-Rspamd-Server: rspam05 X-HE-Tag: 1629024859-469151 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 12, 2021 at 06:14:22PM +0200, Vlastimil Babka wrote: > On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote: > > Get the statistics right; compound pages were being accounted as a > > single page. This didn't matter before now as no filesystem which > > supported compound pages did writeback. Also move the declaration > > to filemap.h since this is part of the page cache. Add a wrapper for > > Seems to be pagemap.h :) Ugh, right. filemap.c. pagemap.h. obviously. > > + wb_stat_mod(wb, WB_RECLAIMABLE, -nr); > > + task_io_account_cancelled_write(folio_size(folio)); > > In "mm/writeback: Add __folio_mark_dirty()" you used nr*PAGE_SIZE. Consistency? We don't have any ;-) I'll change that. Some places we use << PAGE_SHIFT, some places we use * PAGE_SIZE ... either are better than calling folio_size() unnecessarily.