From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294EAC4338F for ; Sun, 15 Aug 2021 15:36:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C1B8C61208 for ; Sun, 15 Aug 2021 15:36:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C1B8C61208 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4BCA86B0072; Sun, 15 Aug 2021 11:36:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46D128D0002; Sun, 15 Aug 2021 11:36:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35B8C6B0074; Sun, 15 Aug 2021 11:36:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 197AF6B0072 for ; Sun, 15 Aug 2021 11:36:08 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B758E180AD807 for ; Sun, 15 Aug 2021 15:36:07 +0000 (UTC) X-FDA: 78477715974.38.38E124A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id 7CC9AF002C99 for ; Sun, 15 Aug 2021 15:36:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eYSk1CsSbdU6TZDzwzr/5Rga7dzOhjq06uCI72Yt8v8=; b=B6xaQgGxdCdoXNp3KRyPOxnERh C/7Lg4rqNcC1kw99i4ixF4K5FBcTzxKmL64L9VVAbhDlrclSCeml39NQUuzmTYLqOBycvaEhvuj3f Lpe3EZD/E27F623ENZ9pQe5q3qaRDcgPVN+g/QE61zunyNWJjEz4r5BHLfkHZObtsSm45Frf65NJs TQcdUo8QCldl6iyH4L9+OCavA7eAR8jmH1pofQlxHYMxI1Fv0Dp8tsKoGm2fQw1QDFSAEvIgRu41H 703a0TmBGOqbvT6oz3RKQ50/X81kDalORq05dqUwZheQsNKZEP9gXnbMCWmcHIRUXrxOhII9Z7x3f W33x5Arg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFIAr-000OO9-Kb; Sun, 15 Aug 2021 15:35:49 +0000 Date: Sun, 15 Aug 2021 16:35:45 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 076/138] mm/writeback: Add folio_redirty_for_writepage() Message-ID: References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-77-willy@infradead.org> <249863ea-8b4b-df38-545a-5f083502270d@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <249863ea-8b4b-df38-545a-5f083502270d@suse.cz> X-Rspamd-Queue-Id: 7CC9AF002C99 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=B6xaQgGx; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam01 X-Stat-Signature: 1qhf6j9a3e3hdhnsdgxhfqbyw6gdqasg X-HE-Tag: 1629041767-609526 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 12, 2021 at 06:30:51PM +0200, Vlastimil Babka wrote: > > +/** > > + * folio_redirty_for_writepage - Decline to write a dirty folio. > > + * @wbc: The writeback control. > > + * @folio: The folio. > > + * > > + * When a writepage implementation decides that it doesn't want to write > > + * @folio for some reason, it should call this function, unlock @folio and > > + * return 0. > > s/0/false ... no? This sentence describes what a writepage implementation should do, and writepage returns an int, not bool.