From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4738C4338F for ; Tue, 17 Aug 2021 05:04:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 89D5960F5E for ; Tue, 17 Aug 2021 05:04:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 89D5960F5E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1E2BE6B006C; Tue, 17 Aug 2021 01:04:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 192896B0072; Tue, 17 Aug 2021 01:04:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ABD26B0073; Tue, 17 Aug 2021 01:04:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id E28456B006C for ; Tue, 17 Aug 2021 01:04:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 704C68249980 for ; Tue, 17 Aug 2021 05:04:54 +0000 (UTC) X-FDA: 78483382908.01.F3885EC Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf24.hostedemail.com (Postfix) with ESMTP id 0830FB0099B3 for ; Tue, 17 Aug 2021 05:04:53 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 136EA60EB5; Tue, 17 Aug 2021 05:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629176693; bh=HGnOeo4oEo1UGFoCN3RyUNNDoCr3GU8htCTpo6xSDTo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d3x8UGVXHHRMBkIRHCn1rk8ocvswnVLbZ3Pc4jlVxOFuBancWFChH1vFZVXmhDMwU 681ipYRO6BQ8Kb8X/eTHQpX2srZBmOeCqxh3GTawi5r0C+FelAkTSQ0WHSYHIugh8A TGgQ8YucKas08d+r4tuyZU+dpGfCgdbFBIj4G/7CrFtypNNsWhjsPqjMTTQXdnvXOD xCtuxopynHnljt4J9Md4cYJbp1qOuDFFpYRU4tXz7G046CjEU1Y2y0MiR5RTAhBXaP L+UFZCNvnVSq47TZhif7ZOVNLFX5oA+Tsf4Jgj6B6deE45SS2lDli4mCZQOZx0fmQq rvs10Jfxu+QBw== Date: Tue, 17 Aug 2021 08:04:46 +0300 From: Mike Rapoport To: Vineet Gupta Cc: linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Anshuman Khandual Subject: Re: [PATCH v2 00/19] ARC mm updates: support 3/4 levels and asm-generic/pgalloc Message-ID: References: <20210812233753.104217-1-vgupta@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 0830FB0099B3 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=d3x8UGVX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org X-Rspamd-Server: rspam04 X-Stat-Signature: acpno3mfdyrjpm7pmryx7crosmcnax5h X-HE-Tag: 1629176693-822653 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 12:58:18PM -0700, Vineet Gupta wrote: > On 8/15/21 2:26 AM, Mike Rapoport wrote: > > On Thu, Aug 12, 2021 at 04:37:34PM -0700, Vineet Gupta wrote: > > > Hi, > > > > > > Big pile of ARC mm changes to prepare for 3 or 4 levels of paging (from > > > current 2) needed for new hardware page walked MMUv6 (in aRCv3 ISA based > > > cores). > > > > > > Most of these changes are incremental cleanups to make way for 14/18 and > > > 15/18 which actually imeplement the new levels (in existing ARCv2 port) > > > and worth a critical eye. > > > > > > CC'ing some of you guys dealing with page tables for a while :-) > > > to spot any obvious gotchas. > > There are a couple of small nits here and there, but overall > > I've fixed the last remaining things locally and won't repost, unless you > want me to. No need. > > > > Acked-by: Mike Rapoport > > Thx for spending time to review this Mike. Much appreciated. You are welcome :) > > -Vineet > > > > > > Thx, > > > -Vineet > > > > > > Changes since v1 [1] > > > - Switched ARC to asm-generic/pgalloc.h (so struct page based pgtable_t) [Mike Rapoport] > > > - Dropped {pud,pmd}_alloc_one/{pud,pmd}_free provided by asm-generic/pgalloc.h [Mike Rapoport] > > > - Negative diffstat now due to above > > > - Added BUILD_BUG_ON() to arch/arc/mm/init.c for sanity of table sizes > > > - Consolidated 2 patches related to ARC_USE_SCRATCH_REG [Mike Rapoport] > > > - Reworked how mmu is re-enabled in entry code [Jose Abreu] > > > > > > [1] http://lists.infradead.org/pipermail/linux-snps-arc/2021-August/005326.html > > > > > > Vineet Gupta (19): > > > ARC: mm: use SCRATCH_DATA0 register for caching pgdir in ARCv2 only > > > ARC: mm: remove tlb paranoid code > > > ARC: mm: move mmu/cache externs out to setup.h > > > ARC: mm: Fixes to allow STRICT_MM_TYPECHECKS > > > ARC: mm: Enable STRICT_MM_TYPECHECKS > > > ARC: ioremap: use more commonly used PAGE_KERNEL based uncached flag > > > ARC: mm: pmd_populate* to use the canonical set_pmd (and drop pmd_set) > > > ARC: mm: switch pgtable_t back to struct page * > > > ARC: mm: switch to asm-generic/pgalloc.h > > > ARC: mm: non-functional code cleanup ahead of 3 levels > > > ARC: mm: move MMU specific bits out of ASID allocator > > > ARC: mm: move MMU specific bits out of entry code ... > > > ARC: mm: disintegrate mmu.h (arcv2 bits out) > > > ARC: mm: disintegrate pgtable.h into levels and flags > > > ARC: mm: hack to allow 2 level build with 4 level code > > > ARC: mm: support 3 levels of page tables > > > ARC: mm: support 4 levels of page tables > > > ARC: mm: vmalloc sync from kernel to user table to update PMD ... > > > ARC: mm: introduce _PAGE_TABLE to explicitly link pgd,pud,pmd entries > > > > > > arch/arc/Kconfig | 7 +- > > > arch/arc/include/asm/cache.h | 4 - > > > arch/arc/include/asm/entry-compact.h | 8 - > > > arch/arc/include/asm/mmu-arcv2.h | 103 +++++++ > > > arch/arc/include/asm/mmu.h | 73 +---- > > > arch/arc/include/asm/mmu_context.h | 28 +- > > > arch/arc/include/asm/page.h | 74 +++-- > > > arch/arc/include/asm/pgalloc.h | 81 ++---- > > > arch/arc/include/asm/pgtable-bits-arcv2.h | 151 +++++++++++ > > > arch/arc/include/asm/pgtable-levels.h | 179 ++++++++++++ > > > arch/arc/include/asm/pgtable.h | 315 +--------------------- > > > arch/arc/include/asm/processor.h | 2 +- > > > arch/arc/include/asm/setup.h | 12 +- > > > arch/arc/kernel/entry-arcv2.S | 1 + > > > arch/arc/kernel/entry.S | 7 +- > > > arch/arc/mm/fault.c | 20 +- > > > arch/arc/mm/init.c | 5 + > > > arch/arc/mm/ioremap.c | 3 +- > > > arch/arc/mm/tlb.c | 68 +---- > > > arch/arc/mm/tlbex.S | 78 ++---- > > > 20 files changed, 591 insertions(+), 628 deletions(-) > > > create mode 100644 arch/arc/include/asm/mmu-arcv2.h > > > create mode 100644 arch/arc/include/asm/pgtable-bits-arcv2.h > > > create mode 100644 arch/arc/include/asm/pgtable-levels.h > > > > > > -- > > > 2.25.1 > > > > -- Sincerely yours, Mike.