From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D2B5C432BE for ; Wed, 25 Aug 2021 23:17:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A09D7610C8 for ; Wed, 25 Aug 2021 23:17:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A09D7610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BE6D36B006C; Wed, 25 Aug 2021 19:17:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6FEA8D0001; Wed, 25 Aug 2021 19:17:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A11716B0073; Wed, 25 Aug 2021 19:17:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 877236B006C for ; Wed, 25 Aug 2021 19:17:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EC0B923E72 for ; Wed, 25 Aug 2021 23:17:36 +0000 (UTC) X-FDA: 78515166912.18.8A258AC Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf19.hostedemail.com (Postfix) with ESMTP id A1552B0000BA for ; Wed, 25 Aug 2021 23:17:36 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id qe12-20020a17090b4f8c00b00179321cbae7so918424pjb.2 for ; Wed, 25 Aug 2021 16:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HHA4dIqDyaRjsKrnG7msKRzMkOmDWIdi+lx15oC+hnY=; b=u53eiPwI4SZX4G1LTTj5mZCu3Zl0AK0XhynL+hMzMjNY/svqjeirm1+N6itwrdCGfT 60BW8cG0grgspqqvF0yPGVSGrl0dDSH5wa/pdWkPwVhVWRMZvWYspQNlDJsSiVejj8EZ u0KMRPOjE7z1+WjNWWmZinwH+HRlG53DiUzm59nCWLYSareoFLP6T3mv8Xc2miTCgwhA AhjJt1+SRiQfKNM5vg6XTMTOK3Y4IQQejAzQi1Z2pzY1mllsZ59e6TlWqHBpv7OnRvwo KC7yhYautjr/1n0pL1zc0C8CQnD0QxXBrL/9yQ1Xp+xChg6Ln0AgRpbOp5h/dGfAKfuy MEVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=HHA4dIqDyaRjsKrnG7msKRzMkOmDWIdi+lx15oC+hnY=; b=UyKASwe6nAZqTCAKPFUhjegXXkDsa3fQq09Eo2TCOqYpREpMQXN/wJOLLQTrqTo8sk tAPBUe8CnEHcLsEYrMtKBhI4UQuC/GjD0x66w0/wPZ+nQ+3k0gS0bm++CEMPY7q8zlmb expWS/c+NZPBT6iswsf5w6C3/dzE348gN9n6hutwDnUMhEpe56YESOm/YBLgs3+bZt6N gzZpPVTop5sPFxg2X0Nhhxh9Tlb0rzQthDj1L8VrTLjbZXCCk9oBUoihs543H5jy8ZXC aksBjKpZwkCFq301kupRvpOjHK2AN9uWdPhRC2Wb4kbvt4Oj2g25GnaWa/3XVNLjevEz GkEw== X-Gm-Message-State: AOAM531Q+ioveiJ9KTvw2VepKVeocxDBnPBJULG6bGrqC9jvXojiRQGu dytz4bUzP0Awr/t6DxZhQKs= X-Google-Smtp-Source: ABdhPJxT3qO3YSJ7a9BGhRAk+eoIFxHo9jpHxEMYeUSUnYscmOhUHreFAXYwbGPgWdDX/wMrRqG2nw== X-Received: by 2002:a17:902:82c6:b0:136:59b0:ed17 with SMTP id u6-20020a17090282c600b0013659b0ed17mr905954plz.61.1629933455556; Wed, 25 Aug 2021 16:17:35 -0700 (PDT) Received: from google.com ([2620:15c:211:201:87f7:83a2:3b32:4366]) by smtp.gmail.com with ESMTPSA id f10sm989244pgm.77.2021.08.25.16.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 16:17:34 -0700 (PDT) Date: Wed, 25 Aug 2021 16:17:32 -0700 From: Minchan Kim To: Andrew Morton Cc: cgoldswo@codeaurora.org, david@redhat.com, linmiaohe@huawei.com, linux-mm@kvack.org, mhocko@suse.com, mm-commits@vger.kernel.org, naoya.horiguchi@nec.com, osalvador@suse.de, stable@vger.kernel.org, torvalds@linux-foundation.org Subject: Re: [patch 1/2] mm/memory_hotplug: fix potential permanent lru cache disable Message-ID: References: <20210825121725.0b4f7ca217e22d9750bc6a6d@linux-foundation.org> <20210825191755.q1BM2fgnb%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210825191755.q1BM2fgnb%akpm@linux-foundation.org> Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=u53eiPwI; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf19.hostedemail.com: domain of minchankim@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=minchankim@gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A1552B0000BA X-Stat-Signature: 6ieeymmxedkemz35qf6fsu9oabesybjo X-HE-Tag: 1629933456-730084 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 25, 2021 at 12:17:55PM -0700, Andrew Morton wrote: > From: Miaohe Lin > Subject: mm/memory_hotplug: fix potential permanent lru cache disable > > If offline_pages failed after lru_cache_disable(), it forgot to do > lru_cache_enable() in error path. So we would have lru cache disabled > permanently in this case. > > Link: https://lkml.kernel.org/r/20210821094246.10149-3-linmiaohe@huawei.com > Fixes: d479960e44f2 ("mm: disable LRU pagevec during the migration temporarily") > Signed-off-by: Miaohe Lin > Reviewed-by: David Hildenbrand > Reviewed-by: Oscar Salvador > Reviewed-by: Naoya Horiguchi > Cc: Chris Goldsworthy > Cc: Michal Hocko > Cc: Minchan Kim > Cc: > Signed-off-by: Andrew Morton Acked-by: Minchan Kim Thanks for catching.