From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A20C432BE for ; Mon, 30 Aug 2021 10:08:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB2F3610A8 for ; Mon, 30 Aug 2021 10:08:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CB2F3610A8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6F2676B0071; Mon, 30 Aug 2021 06:08:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A22A6B0072; Mon, 30 Aug 2021 06:08:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5916C8D0001; Mon, 30 Aug 2021 06:08:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 4B09D6B0071 for ; Mon, 30 Aug 2021 06:08:49 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D90AA181AF5D8 for ; Mon, 30 Aug 2021 10:08:48 +0000 (UTC) X-FDA: 78531323136.21.2CE22FD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 9177B90001BC for ; Mon, 30 Aug 2021 10:08:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OwN0qd7H75DOHWHeRi7A6OxOpQZetRKT2crFWsG6Hm4=; b=EHzlxk25V3My1JjJ+Q9axYX5UC TcDp2UiAb+x1iRaM2WVlZxjq6f1J35NYFQ4zSUUZE0ckFxnk5E31VVJj5K1pTqLBwl2GQ6t1+tEpd cMPGzW2KtVqOWYzBtDw5fvEMPmp3I9cvmeYd+1h48c7luHT1onUwn9wVKojG26h801aKNwqRkGV5v wAaeOqnhAUCy4hgyGQGfSKNitGapgdYhSpruVZMuGUb4kVje5426jfD6TS+5PFhExT5mMntPaKDZr G5kxHFegwqtV/lA0v+bh6pKfzFcT6iWhWfjMTal7oxXHqfP9ZawveCNS5ucgTB0vIyezps7rZQuZr zBY55/yw==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKeD1-00Hb56-Ru; Mon, 30 Aug 2021 10:08:12 +0000 Date: Mon, 30 Aug 2021 11:08:07 +0100 From: Christoph Hellwig To: Yafang Shao Cc: Christoph Hellwig , Andrew Morton , Linux MM , "Kirill A . Shutemov" Subject: Re: [PATCH] mm, gpu: fix error when FOLL_MLOCK an unpresent page Message-ID: References: <20210829011953.9051-1-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=EHzlxk25; spf=none (imf29.hostedemail.com: domain of BATV@casper.srs.infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=BATV@casper.srs.infradead.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9177B90001BC X-Stat-Signature: 4za88cfkrf68u8scr6aq6s3btdk63s1q X-HE-Tag: 1630318127-967068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 30, 2021 at 05:12:32PM +0800, Yafang Shao wrote: > > Which is not a valid way to call get_user_pages. What we need to do is > > to reject that case. > > Do you mean below change ? Sory of. I think once touching this we should do a few more cleanups including making many of the flags private to gup.c. I'll try to find some time to post a more complete series.