From: Huang Shijie <shijie@os.amperecomputing.com>
To: David Hildenbrand <david@redhat.com>
Cc: viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
jlayton@kernel.org, bfields@fieldses.org,
torvalds@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
song.bao.hua@hisilicon.com, patches@amperecomputing.com,
zwang@amperecomputing.com
Subject: Re: [RFC PATCH] fs/exec: Add the support for ELF program's NUMA replication
Date: Thu, 9 Sep 2021 09:46:20 +0000 [thread overview]
Message-ID: <YTnX7IyC420MNBLq@hsj> (raw)
In-Reply-To: <2cb841ca-2a04-f088-cee2-6c020ecc9508@redhat.com>
On Mon, Sep 06, 2021 at 11:35:01AM +0200, David Hildenbrand wrote:
> On 06.09.21 18:16, Huang Shijie wrote:
> > This patch adds AT_NUMA_REPLICATION for execveat().
> >
> > If this flag is set, the kernel will trigger COW(copy on write)
> > on the mmapped ELF binary. So the program will have a copied-page
> > on its NUMA node, even if the original page in page cache is
> > on other NUMA nodes.
>
> Am I missing something important or is this just absolutely not what we
> want?
Please see the thread:
https://marc.info/?l=linux-kernel&m=163070220429222&w=2
Linus did not think it is a good choice to implement the "per-numa node page cache"
>
> This means that for each and every invocation of the binary, we'll COW the
> complete binary -- an awful lot of wasted main memory and swap.
Only the one who cares about the performance in NUMA will use this interface.
Most of the people never use it..
Thanks
Huang Shijie
next prev parent reply other threads:[~2021-09-09 1:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 16:16 [RFC PATCH] fs/exec: Add the support for ELF program's NUMA replication Huang Shijie
2021-09-06 9:35 ` David Hildenbrand
2021-09-09 9:46 ` Huang Shijie [this message]
2021-09-09 8:58 ` David Hildenbrand
2021-09-06 12:09 ` Matthew Wilcox
2021-09-09 9:48 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTnX7IyC420MNBLq@hsj \
--to=shijie@os.amperecomputing.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=david@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patches@amperecomputing.com \
--cc=song.bao.hua@hisilicon.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zwang@amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).