From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D19BC433EF for ; Fri, 24 Sep 2021 04:35:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9EC0C61241 for ; Fri, 24 Sep 2021 04:35:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9EC0C61241 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E6D416B006C; Fri, 24 Sep 2021 00:35:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF59A6B0071; Fri, 24 Sep 2021 00:35:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBC4E900002; Fri, 24 Sep 2021 00:35:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id B84446B006C for ; Fri, 24 Sep 2021 00:35:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 757488249980 for ; Fri, 24 Sep 2021 04:35:17 +0000 (UTC) X-FDA: 78621202674.18.B8DEFBA Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [142.44.231.140]) by imf17.hostedemail.com (Postfix) with ESMTP id F21A4F000090 for ; Fri, 24 Sep 2021 04:35:16 +0000 (UTC) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTcvS-006r8Z-Mj; Fri, 24 Sep 2021 04:35:06 +0000 Date: Fri, 24 Sep 2021 04:35:06 +0000 From: Al Viro To: yangerkun Cc: akpm@linux-foundation.org, jack@suse.cz, gregkh@linuxfoundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, yukuai3@huawei.com Subject: Re: [PATCH] ramfs: fix mount source show for ramfs Message-ID: References: <20210811122811.2288041-1-yangerkun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811122811.2288041-1-yangerkun@huawei.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F21A4F000090 X-Stat-Signature: r43fgb8hr4rwzim18uqdabrx3413f655 Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=none (imf17.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 142.44.231.140) smtp.mailfrom=viro@ftp.linux.org.uk X-HE-Tag: 1632458116-753337 X-Bogosity: Ham, tests=bogofilter, spamicity=0.250349, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 11, 2021 at 08:28:11PM +0800, yangerkun wrote: > ramfs_parse_param does not parse key "source", and will convert > -ENOPARAM to 0. This will skip vfs_parse_fs_param_source in > vfs_parse_fs_param, which lead always "none" mount source for ramfs. Fix > it by parse "source" in ramfs_parse_param. > > Signed-off-by: yangerkun > --- > fs/ramfs/inode.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c > index 65e7e56005b8..0d7f5f655fd8 100644 > --- a/fs/ramfs/inode.c > +++ b/fs/ramfs/inode.c > @@ -202,6 +202,10 @@ static int ramfs_parse_param(struct fs_context *fc, struct fs_parameter *param) > struct ramfs_fs_info *fsi = fc->s_fs_info; > int opt; > > + opt = vfs_parse_fs_param_source(fc, param); > + if (opt != -ENOPARAM) > + return opt; > + > opt = fs_parse(fc, ramfs_fs_parameters, param, &result); > if (opt < 0) { > /* Umm... If anything, I would rather call that thing *after* fs_parse() gives negative, similar to what kernel/cgroup/cgroup-v1.c does.