From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42939C433FE for ; Tue, 21 Sep 2021 18:03:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6305610A0 for ; Tue, 21 Sep 2021 18:03:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6305610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 69C47900002; Tue, 21 Sep 2021 14:03:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64B456B0071; Tue, 21 Sep 2021 14:03:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53AA3900002; Tue, 21 Sep 2021 14:03:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 466F36B006C for ; Tue, 21 Sep 2021 14:03:34 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 032308249980 for ; Tue, 21 Sep 2021 18:03:34 +0000 (UTC) X-FDA: 78612353148.33.8366717 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id AD22C555EF7E for ; Tue, 21 Sep 2021 18:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632247413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o2gyCGlUrboNcIiNieqE+IfjFr7udGGsuUiWMYUkrwc=; b=eqNExlImFOC7IvaOy4NfMdGeXMAax1qJO5Y/Z4cZjlg6iEda0JLDB5K7Foa076rlgCFSMY VOSDxEwbsXcRbbm3zCLBg5jAnC9e+MSboXGTNmi03Nsn+ncsTNCPwHpO0Q2ppW37tYmIyZ IStyvjjGSr8eH4j5IlDgTBAo6n6fc6Q= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-202-_ApYn2zyM2GiXd1WjSycvQ-1; Tue, 21 Sep 2021 14:03:31 -0400 X-MC-Unique: _ApYn2zyM2GiXd1WjSycvQ-1 Received: by mail-qk1-f198.google.com with SMTP id s18-20020a05620a255200b00433885d4fa7so819143qko.4 for ; Tue, 21 Sep 2021 11:03:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o2gyCGlUrboNcIiNieqE+IfjFr7udGGsuUiWMYUkrwc=; b=lKPtfOkU0JoPUFp8bVP1S+s/ezQUNW06F6vZi4pDgsry+hc69HLhtcbec+qy2l6iqk +TWPLa8DD4d010vlYcLy+BqmR+wvpdRkgNiTRUVMtyCL7Pt8gZiDuZwx7r11RqMDk/FR 32p/M+utLBSjQSD0YPrgscvgxhieC8xilxpPzYqZe9pxv2XIomra/yB2q1JAFi2cj6um lsH8Chd4sepoSndgUhtDtrZdtVuT/loIO4KF2at7zs+7w07xm4oK5yPgDmLvdrRViUSN 3gt6XncU3ko6WOL60O4U3o+nI8YPh+/mNi8DpV6y89elWUnI0FBX11Cr+5D3JX36ODK5 Xg1A== X-Gm-Message-State: AOAM530ytb41l0aOxnox7XSbOSzO2+8VnfrvgEo67//xM2xOQ1kjHTZT QpxCPoBQELm2yPAP+n+/L3m/bRvZRTzMPLHhwso3jBGWLQWXESS6f+fdc0pxP8sScXxu3g7niTL G6e/Q55FBw2w= X-Received: by 2002:ac8:4e11:: with SMTP id c17mr15690800qtw.400.1632247411189; Tue, 21 Sep 2021 11:03:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxa0LEMQ/1ArgdueEZqR3M76Qxk5uPrMK6duFpGckfUHr9iZTOK6FREBkxU98G4YICtISCcfg== X-Received: by 2002:ac8:4e11:: with SMTP id c17mr15690771qtw.400.1632247410936; Tue, 21 Sep 2021 11:03:30 -0700 (PDT) Received: from t490s ([2607:fea8:56a2:9100::d3ec]) by smtp.gmail.com with ESMTPSA id d5sm3792039qtr.61.2021.09.21.11.03.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 11:03:30 -0700 (PDT) Date: Tue, 21 Sep 2021 14:03:29 -0400 From: Peter Xu To: Axel Rasmussen Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] userfaultfd/selftests: don't rely on GNU extensions for random numbers Message-ID: References: <20210921163323.944352-1-axelrasmussen@google.com> <20210921163323.944352-3-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20210921163323.944352-3-axelrasmussen@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AD22C555EF7E X-Stat-Signature: iok15uc138fr7axt5dhuwbzi3e5zi699 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eqNExlIm; spf=none (imf01.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1632247413-608889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000374, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 21, 2021 at 09:33:23AM -0700, Axel Rasmussen wrote: > Two arguments for doing this: > > First, and maybe most importantly, the resulting code is significantly > shorter / simpler. > > Then, we avoid using GNU libc extensions. Why does this matter? It makes > testing userfaultfd with the selftest easier e.g. on distros which use > something other than glibc (e.g., Alpine, which uses musl); basically, > it makes the test more portable. > > Signed-off-by: Axel Rasmussen Reviewed-by: Peter Xu -- Peter Xu