From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7897DC433EF for ; Thu, 7 Oct 2021 19:31:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 272E760F90 for ; Thu, 7 Oct 2021 19:31:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 272E760F90 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B32146B0071; Thu, 7 Oct 2021 15:31:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE1A06B0072; Thu, 7 Oct 2021 15:31:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D0EC6B0074; Thu, 7 Oct 2021 15:31:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 904D36B0071 for ; Thu, 7 Oct 2021 15:31:36 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3C4FF1842B11C for ; Thu, 7 Oct 2021 19:31:36 +0000 (UTC) X-FDA: 78670635792.06.40A807D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id E60C85077A5C for ; Thu, 7 Oct 2021 19:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5ov7Y3AdM9RNZqm8EP9Y9K5HZHbQg0Tk3kW4wZrNisU=; b=wIKTf0/Xx58Dcd+75FXYhO6TpO wOvrjbzdXRPaGAIp1B1H3BfnXW/D/XaSolWgQH7tlfq4Jkqz+w13NdPhBwQa3QV/yChIvCwtXUxso llNdNzLEvCd44R612N2acyNWet3H8LjMs4GXuI1A2tSElqgflZNgdsKHJ9XbDW2BOTjlqUTFANF/A 3vFjuUiA3Dau1FUjzThJ9z2w3yu8YuEnDod1RVht3dwOmgeVVFr7NLtIiP2prd4UiHnbjBwuMK6m+ udsyXpFpBz7v7cN55kp3uNmjx6cn+wVK4eXBw7osEDLtkQe3jsdQosqK70vT1MqP0CV/diU2dGLLh qpAYb5kQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYZ5t-002MV4-KT; Thu, 07 Oct 2021 19:30:32 +0000 Date: Thu, 7 Oct 2021 20:30:17 +0100 From: Matthew Wilcox To: Anders Roxell Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, viresh.kumar@linaro.org Subject: Re: [RFC PATCH] fs: proc: task_mmu: fix sparse warnings Message-ID: References: <20211007191636.541041-1-anders.roxell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211007191636.541041-1-anders.roxell@linaro.org> X-Rspamd-Queue-Id: E60C85077A5C X-Stat-Signature: bm88ejh3ykapbrnnqw3s8pwn6h1z8kuh Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="wIKTf0/X"; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspamd-Server: rspam06 X-HE-Tag: 1633635095-177532 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 07, 2021 at 09:16:36PM +0200, Anders Roxell wrote: > When building the kernel with sparse enabled 'C=1' the following > warnings can be seen: > > fs/proc/task_mmu.c:587:17: warning: context imbalance in 'smaps_pte_range' - unexpected unlock > fs/proc/task_mmu.c:1145:28: warning: context imbalance in 'clear_refs_pte_range' - unexpected unlock > fs/proc/task_mmu.c:1473:28: warning: context imbalance in 'pagemap_pmd_range' - unexpected unlock > fs/proc/task_mmu.c:1811:28: warning: context imbalance in 'gather_pte_stats' - unexpected unlock > > Rework to add __acquire() and __release() to tell sparse that it is all good. Surely the root problem here is that pmd_trans_huge_lock() isn't marked with __cond_lock() like, eg, get_locked_pte() is?