From: Michal Hocko <mhocko@suse.com>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
Neil Brown <neilb@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [RFC 2/3] mm/vmalloc: add support for __GFP_NOFAIL
Date: Wed, 20 Oct 2021 11:18:15 +0200 [thread overview]
Message-ID: <YW/e19fLyUy7ohR6@dhcp22.suse.cz> (raw)
In-Reply-To: <YW/SYl/ZKp7W60mg@dhcp22.suse.cz>
On Wed 20-10-21 10:25:06, Michal Hocko wrote:
[...]
> > > The flag itself is not really necessary down there as long as we
> > > guarantee that the high level logic doesn't fail. In this case we keep
> > > retrying at __vmalloc_node_range level which should be possible to cover
> > > all callers that can control gfp mask. I was thinking to put it into
> > > __get_vm_area_node but that was slightly more hairy and we would be
> > > losing the warning which might turn out being helpful in cases where the
> > > failure is due to lack of vmalloc space or similar constrain. Btw. do we
> > > want some throttling on a retry?
> > >
> > I think adding kind of schedule() will not make things worse and in corner
> > cases could prevent a power drain by CPU. It is important for mobile devices.
>
> I suspect you mean schedule_timeout here? Or cond_resched? I went with a
> later for now, I do not have a good idea for how to long to sleep here.
> I am more than happy to change to to a sleep though.
Forgot to paste the follow up I have staged currently
---
commit 66fea55e5543fa234692a70144cd63c7a1bca32f
Author: Michal Hocko <mhocko@suse.com>
Date: Wed Oct 20 10:12:45 2021 +0200
fold me "mm/vmalloc: add support for __GFP_NOFAIL"
- add cond_resched
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 0fb5413d9239..f7098e616883 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -2944,6 +2944,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask,
do {
ret = vmap_pages_range(addr, addr + size, prot, area->pages,
page_shift);
+ cond_resched();
} while ((gfp_mask & __GFP_NOFAIL) && (ret < 0));
if ((gfp_mask & (__GFP_FS | __GFP_IO)) == __GFP_IO)
@@ -3034,8 +3035,10 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
warn_alloc(gfp_mask, NULL,
"vmalloc error: size %lu, vm_struct allocation failed",
real_size);
- if (gfp_mask & __GFP_NOFAIL)
+ if (gfp_mask & __GFP_NOFAIL) {
+ cond_resched();
goto again;
+ }
goto fail;
}
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-10-20 9:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 11:47 [RFC 0/3] extend vmalloc support for constrained allocations Michal Hocko
2021-10-18 11:47 ` [RFC 1/3] mm/vmalloc: alloc GFP_NO{FS,IO} for vmalloc Michal Hocko
2021-10-19 0:44 ` NeilBrown
2021-10-19 6:59 ` Michal Hocko
2021-10-18 11:47 ` [RFC 2/3] mm/vmalloc: add support for __GFP_NOFAIL Michal Hocko
2021-10-18 16:48 ` Michal Hocko
2021-10-19 11:06 ` Uladzislau Rezki
2021-10-19 11:52 ` Michal Hocko
2021-10-19 19:46 ` Uladzislau Rezki
2021-10-20 8:25 ` Michal Hocko
2021-10-20 9:18 ` Michal Hocko [this message]
2021-10-20 13:54 ` Uladzislau Rezki
2021-10-20 14:06 ` Michal Hocko
2021-10-20 14:29 ` Uladzislau Rezki
2021-10-20 14:53 ` Michal Hocko
2021-10-20 15:00 ` Uladzislau Rezki
2021-10-20 19:24 ` Uladzislau Rezki
2021-10-21 8:56 ` Michal Hocko
2021-10-21 10:13 ` NeilBrown
2021-10-21 10:27 ` Michal Hocko
2021-10-21 10:40 ` Uladzislau Rezki
2021-10-21 22:49 ` NeilBrown
2021-10-22 8:18 ` Michal Hocko
2021-10-25 9:48 ` Uladzislau Rezki
2021-10-25 11:20 ` Michal Hocko
2021-10-25 14:30 ` Uladzislau Rezki
2021-10-25 14:56 ` Michal Hocko
2021-10-25 23:50 ` NeilBrown
2021-10-26 7:16 ` Michal Hocko
2021-10-26 10:24 ` NeilBrown
2021-10-26 14:25 ` Uladzislau Rezki
2021-10-26 14:43 ` Michal Hocko
2021-10-26 15:40 ` Uladzislau Rezki
2021-10-20 8:25 ` [PATCH] mm/vmalloc: be more explicit about supported gfp flags Michal Hocko
2021-10-18 11:47 ` [RFC 3/3] mm: allow !GFP_KERNEL allocations for kvmalloc Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW/e19fLyUy7ohR6@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).