From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA6EC433FE for ; Mon, 11 Oct 2021 12:30:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D26A60E9C for ; Mon, 11 Oct 2021 12:30:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5D26A60E9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D0EAC6B006C; Mon, 11 Oct 2021 08:30:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CBEFC900002; Mon, 11 Oct 2021 08:30:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BAD126B0072; Mon, 11 Oct 2021 08:30:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id A87226B006C for ; Mon, 11 Oct 2021 08:30:04 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 549FD82499A8 for ; Mon, 11 Oct 2021 12:30:04 +0000 (UTC) X-FDA: 78684088728.30.A504AAF Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf22.hostedemail.com (Postfix) with ESMTP id 099EC2363 for ; Mon, 11 Oct 2021 12:30:03 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id y12so54176460eda.4 for ; Mon, 11 Oct 2021 05:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8R0yE/cxVHvwquZPbOltOEz0D9tBHQM+oAeyj/5Oe7w=; b=FXzOL5LCnisbrGuuwRWxxVgnOol92yY0RKTJyFSRNA1ojvkI4GQAWxO2KF+j+QRKsu u98Cb8IdU1MYdndfLNE1l03Rfo6rOjDQIhFBnZx4aWXvlrMf2Uv8gUk2ke5rqKeVxs3S YGtwOiVjbdzn4KlA/LfgSIA46/QELQHyML6B4VkL+h8zgu3VSCJio80xD755bgcHYYaz kEe6szTyd9eV//ngArOWp3CjAmjZZSC8TWLqdlsUD4nbcWS4g+bRCBit27oO6cU7653k GHdivWTSzwu+vG11755m46kgU3w6yjkSTmOb4etRTsbdTNZoZwVaFHueYGPfTOhMQghO tv8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8R0yE/cxVHvwquZPbOltOEz0D9tBHQM+oAeyj/5Oe7w=; b=jI/A3Grpqu4n/r0kmP3AjUPA23jZBXJcytOZ7WGFmenRgqYMkkAwwRwN5Z7yztCsEy Ij3SZpBdZZ7RmWxPf2qG5MKKx2O7A8tp/XYpExjpiQF2n/3kY9CPmt+HZVxLk8ief5M6 4p79OcTVpRnZyBVm2GzwjV7UnrFwO9SXLC7cTC3JS4Piw/6WPYC54GIjdpOHZzeyvjFx gv+zXmLkN5vcxyPto6xlxKtu2BihEik00EMwEY+oww2EQIk6MkTsQ2HerQC0J8H3/xUk uU64Ofv2WbWhYqadNokz0GrQLzPt+mTMS4p5IevQee8oHnRdrgT1TLXyfdlVC3tJIz+x 1M9g== X-Gm-Message-State: AOAM533J6BWapQrhXvhZfMEs54I/7nPq7LgEdHdtg70cHxYIa9ihwOU3 AeOte6TNF6KWVJu9JOiPeA6xmQ== X-Google-Smtp-Source: ABdhPJxbSB+nDpde8OFxNgOlGrt5t5L/HD+mZszO/+/8GWvGG8Zhv5Z+6xVUSEKeSarJ6WKBDu/DOw== X-Received: by 2002:a50:bf05:: with SMTP id f5mr40394285edk.156.1633955402530; Mon, 11 Oct 2021 05:30:02 -0700 (PDT) Received: from apalos.home (ppp-94-66-220-73.home.otenet.gr. [94.66.220.73]) by smtp.gmail.com with ESMTPSA id f26sm4159873edr.8.2021.10.11.05.30.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Oct 2021 05:30:02 -0700 (PDT) Date: Mon, 11 Oct 2021 15:29:58 +0300 From: Ilias Apalodimas To: Jesper Dangaard Brouer Cc: John Hubbard , Yunsheng Lin , davem@davemloft.net, kuba@kernel.org, brouer@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org, akpm@linux-foundation.org, hawk@kernel.org, peterz@infradead.org, yuzhao@google.com, will@kernel.org, willy@infradead.org, jgg@ziepe.ca, mcroce@microsoft.com, willemb@google.com, cong.wang@bytedance.com, pabeni@redhat.com, haokexin@gmail.com, nogikh@google.com, elver@google.com, memxor@gmail.com, vvs@virtuozzo.com, linux-mm@kvack.org, edumazet@google.com, alexander.duyck@gmail.com, dsahern@gmail.com Subject: Re: [PATCH net-next -v5 3/4] mm: introduce __get_page() and __put_page() Message-ID: References: <20211009093724.10539-1-linyunsheng@huawei.com> <20211009093724.10539-4-linyunsheng@huawei.com> <62106771-7d2a-3897-c318-79578360a88a@nvidia.com> <89bcc42a-ad95-e729-0748-bf394bf770be@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89bcc42a-ad95-e729-0748-bf394bf770be@redhat.com> Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=FXzOL5LC; spf=pass (imf22.hostedemail.com: domain of ilias.apalodimas@linaro.org designates 209.85.208.51 as permitted sender) smtp.mailfrom=ilias.apalodimas@linaro.org; dmarc=pass (policy=none) header.from=linaro.org X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 099EC2363 X-Stat-Signature: 6dyurdfda1a77rr9nzdaks7oju5extrn X-HE-Tag: 1633955403-278056 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 11, 2021 at 02:25:08PM +0200, Jesper Dangaard Brouer wrote: > > > On 09/10/2021 21.49, John Hubbard wrote: > > So in case it's not clear, I'd like to request that you drop this one > > patch from your series. > > In my opinion as page_pool maintainer, you should also drop patch 4/4 from > this series. > > I like the first two patches, and they should be resend and can be applied > without too much further discussion. +1 That's what I hinted on the previous version. The patches right now go way beyond the spec of page pool. We are starting to change core networking functions and imho we need a lot more people involved in this discussion, than the ones participating already. As a general note and the reason I am so hesitant, is that we are starting to violate layers here (at least in my opinion). When the recycling was added, my main concern was to keep the network stack unaware (apart from the skb bit). Now suddenly we need to teach frag_ref/unref internal page pool counters and that doesn't feel right. We first need to prove the race can actually happen, before starting to change things. Regards /Ilias > > --Jesper >