From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0775AC433EF for ; Sun, 17 Oct 2021 13:48:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C29C60FD8 for ; Sun, 17 Oct 2021 13:48:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7C29C60FD8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 0390E6B006C; Sun, 17 Oct 2021 09:48:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2B286B0072; Sun, 17 Oct 2021 09:48:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1A5F900002; Sun, 17 Oct 2021 09:48:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id CED436B006C for ; Sun, 17 Oct 2021 09:48:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 846131802FA37 for ; Sun, 17 Oct 2021 13:48:26 +0000 (UTC) X-FDA: 78706059012.26.0B53E1B Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by imf14.hostedemail.com (Postfix) with ESMTP id 920276001980 for ; Sun, 17 Oct 2021 13:48:25 +0000 (UTC) Received: from netfilter.org (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id 12A8E63EE1; Sun, 17 Oct 2021 15:46:41 +0200 (CEST) Date: Sun, 17 Oct 2021 15:48:16 +0200 From: Pablo Neira Ayuso To: Lukas Wunner Cc: Jozsef Kadlecsik , Florian Westphal , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, llvm@lists.linux.dev, kbuild-all@lists.01.org, linux-mm@kvack.org, Nathan Chancellor Subject: Re: [PATCH nf-next] netfilter: core: Fix clang warnings about unused static inlines Message-ID: References: <202110160632.WzahPgao-lkp@intel.com> <7bc9f3ee15533d170bc412d6bcdd122632af169d.1634370995.git.lukas@wunner.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7bc9f3ee15533d170bc412d6bcdd122632af169d.1634370995.git.lukas@wunner.de> Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of pablo@netfilter.org designates 217.70.188.207 as permitted sender) smtp.mailfrom=pablo@netfilter.org X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 920276001980 X-Stat-Signature: qftrm8e7dqq6or81r9q63m9czm6rtens X-HE-Tag: 1634478505-62211 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 16, 2021 at 10:13:27AM +0200, Lukas Wunner wrote: > Unlike gcc, clang warns about unused static inlines that are not in an > include file: > > net/netfilter/core.c:344:20: error: unused function 'nf_ingress_hook' [-Werror,-Wunused-function] > static inline bool nf_ingress_hook(const struct nf_hook_ops *reg, int pf) > ^ > net/netfilter/core.c:353:20: error: unused function 'nf_egress_hook' [-Werror,-Wunused-function] > static inline bool nf_egress_hook(const struct nf_hook_ops *reg, int pf) > ^ > > According to commit 6863f5643dd7 ("kbuild: allow Clang to find unused > static inline functions for W=1 build"), the proper resolution is to > mark the affected functions as __maybe_unused. An alternative approach > would be to move them to include/linux/netfilter_netdev.h, but since > Pablo didn't do that in commit ddcfa710d40b ("netfilter: add > nf_ingress_hook() helper function"), I'm guessing __maybe_unused is > preferred. > > This fixes both the warning introduced by Pablo in v5.10 as well as the > one recently introduced by myself with commit 42df6e1d221d ("netfilter: > Introduce egress hook"). Applied, thanks.