From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AA13C433EF for ; Thu, 21 Oct 2021 12:03:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB9B86120C for ; Thu, 21 Oct 2021 12:03:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AB9B86120C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 106C8940008; Thu, 21 Oct 2021 08:03:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B5B9900002; Thu, 21 Oct 2021 08:03:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0DB8940008; Thu, 21 Oct 2021 08:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id E0538900002 for ; Thu, 21 Oct 2021 08:03:41 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 815C730C74 for ; Thu, 21 Oct 2021 12:03:41 +0000 (UTC) X-FDA: 78720310242.21.5B675EB Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf18.hostedemail.com (Postfix) with ESMTP id 724EC4002093 for ; Thu, 21 Oct 2021 12:03:37 +0000 (UTC) Received: by mail-qk1-f179.google.com with SMTP id j12so797423qkk.5 for ; Thu, 21 Oct 2021 05:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=luh0TIccmegXn8CJKJYKcwVKTjrSX33i0YnsKW7PqRo=; b=qGD4VnPE++cf1r2/FKV86F0A1UAugCAyIHl5wNZ1vD6jCIWAMUT6Rwb653yetmU3Ns w0ZJCx+yf0nvzehRE0j3tWpUfb2T1Oe1dc1ZcBtlB2Xj05XeWvCCffAID3/dyEVh73m0 hLUWc1vUsqc5fm5fLmyIU11Ht1P/+cxVUBvrbvwSWLw3TTGjonEQNQCATPY0G5mCYsf/ NoSDHyefyqDLnv6PiaDrkB4tlzLueZPa9b62UECl9lavceDHw4HQFcm91z9i/wEGdJFY 4yyd/9f3U21RxJGO88adsptB1gHxmpPqufPNYtAQXwRAql0yw+BZ/CggLOqHZYPHErmP /UPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=luh0TIccmegXn8CJKJYKcwVKTjrSX33i0YnsKW7PqRo=; b=M8oZ23q0AwFZRcDicCm7B7u3tc6hLkD0VKAH/Ql/CbY6fiHnEgI2OeoDM4pWidIh0I qyeEDGGNEUYWYq9vNd/788XlZgxoECB74WGIpgjW5z4xsTxCykFNvvKdatxI0doxDryL u9n+TM1CGPrL3MzT7q8cDRKi+M61CXimvAXmUQPkC2JzPrqYFG1wQrcVVJG/KezE2M2C BQDoHEydIw3xtvgWpsSSkemGCJ6mGp8zFG/mX6Sfp6YM5JT/mgSOiy3x1BRD94Xz5dVZ lRPnTeZ21pI7C5Hjvuche6OtQwd7d1MlfQ8D0LnabEfIdR0TpQyTMo1LatvxVcJeIUV3 wZWg== X-Gm-Message-State: AOAM5338CPbLh2Z8pkM+lxBne23FmLb4TR7fg96Laab6kZzJx3QPLlTg ZXAqdXSAfD792Ww5QvRD1w== X-Google-Smtp-Source: ABdhPJwd1ait2YAPoGPfPub3ytuA8mdp1mQxCnWuEJN0VmzllJMSSscBuA4UgH+C3yQkZAYHcnKxAQ== X-Received: by 2002:a37:b307:: with SMTP id c7mr4157659qkf.134.1634817820520; Thu, 21 Oct 2021 05:03:40 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id l3sm2474608qkj.110.2021.10.21.05.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 05:03:39 -0700 (PDT) Date: Thu, 21 Oct 2021 08:03:37 -0400 From: Kent Overstreet To: David Hildenbrand Cc: Christoph Hellwig , Matthew Wilcox , Johannes Weiner , "Kirill A. Shutemov" , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , "Darrick J. Wong" , David Howells , Hugh Dickins Subject: Re: Folios for 5.15 request - Was: re: Folio discussion recap - Message-ID: References: <20211018231627.kqrnalsi74bgpoxu@box.shutemov.name> <996b3ac4-1536-2152-f947-aad6074b046a@redhat.com> <436a9f9c-d5af-7d12-b7d2-568e45ffe0a0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 724EC4002093 X-Stat-Signature: 153jht5mbkrt9fi5814um5yp3a9h6pgg Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qGD4VnPE; spf=pass (imf18.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.179 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1634817817-760239 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 21, 2021 at 09:21:17AM +0200, David Hildenbrand wrote: > On 21.10.21 08:51, Christoph Hellwig wrote: > > FYI, with my block and direct I/O developer hat on I really, really > > want to have the folio for both file and anon pages. Because to make > > the get_user_pages path a _lot_ more efficient it should store folios. > > And to make that work I need them to work for file and anon pages > > because for get_user_pages and related code they are treated exactly > > the same. ++ > Thanks, I can understand that. And IMHO that would be even possible with > split types; the function prototype will simply have to look a little > more fancy instead of replacing "struct page" by "struct folio". :) Possible yes, but might it be a little premature to split them?