From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0361BC433F5 for ; Thu, 21 Oct 2021 12:38:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A3FFE60E05 for ; Thu, 21 Oct 2021 12:38:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A3FFE60E05 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C9D9A94000E; Thu, 21 Oct 2021 08:38:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4BDA900002; Thu, 21 Oct 2021 08:38:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B135994000E; Thu, 21 Oct 2021 08:38:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id A3467900002 for ; Thu, 21 Oct 2021 08:38:39 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5B23D30C6E for ; Thu, 21 Oct 2021 12:38:39 +0000 (UTC) X-FDA: 78720398358.40.5D9E91B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id CEDB7801A8A8 for ; Thu, 21 Oct 2021 12:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b97dcGvMvaI7aNoEUbcHH/tMuj2TYYPHMA+1H8wp8Qo=; b=aAkW3J2JlENuuKlasNEJbAmEsN H2+y0RaYxX/Q16d8wL73pYeNZClhK5KLJIcjOSaTtEKLqCvZwDX/k6V9kFsm3l1kN87LKJvpeZ1OH C4JnuFj6UkqRr6bsFdyrlKUjJ5WrSOlXwQyCv5N49FBJF41IIH0GWpSNy+H0U4cGP4ZssIqyG6yfr myeYp5/82dZZzQkVD7va6x00m8hRH/QA6FQQMw03GURemKYoUFjgA8ecByqppNcEbMd3g5L8pT2yg xRa05XyI9uYXJifIpoFPvVGm8hP0T9H2IlUKPdu4w7mAd6lRE8LW1irQdoYIVN7CbpWZE/ACwcfeg B7HAqONw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdXL3-007WMs-Ra; Thu, 21 Oct 2021 12:38:29 +0000 Date: Thu, 21 Oct 2021 05:38:29 -0700 From: Christoph Hellwig To: David Hildenbrand Cc: Kent Overstreet , Christoph Hellwig , Matthew Wilcox , Johannes Weiner , "Kirill A. Shutemov" , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , "Darrick J. Wong" , David Howells , Hugh Dickins Subject: Re: Folios for 5.15 request - Was: re: Folio discussion recap - Message-ID: References: <20211018231627.kqrnalsi74bgpoxu@box.shutemov.name> <996b3ac4-1536-2152-f947-aad6074b046a@redhat.com> <436a9f9c-d5af-7d12-b7d2-568e45ffe0a0@redhat.com> <2fc2c5da-c0e9-b954-ba48-e258b88e3271@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2fc2c5da-c0e9-b954-ba48-e258b88e3271@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CEDB7801A8A8 X-Stat-Signature: wij843gaqhx9tch43js8tu8tjb14pou6 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=aAkW3J2J; dmarc=none; spf=none (imf06.hostedemail.com: domain of BATV+f538400d2eeb65ed2b85+6633+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f538400d2eeb65ed2b85+6633+infradead.org+hch@bombadil.srs.infradead.org X-HE-Tag: 1634819917-724126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 21, 2021 at 02:35:32PM +0200, David Hildenbrand wrote: > My opinion after all the discussions: use a dedicate type with a clear > name to solve the immediate filemap API issue. Leave the remainder alone > for now. Less code to touch, less subsystems to involve (well, still a > lot), less people to upset, less discussions to have, faster review, > faster upstream, faster progress. A small but reasonable step. I don't get it. I mean I'm not the MM expert, I've only been touching most areas of it occasionally for the last 20 years, but anon and file pages have way more in common both in terms of use cases and implementation than what is different (unlike some of the other (ab)uses of struct page). What is the point of splitting it now when there are tons of use cases where they are used absolutely interchangable both in consumers of the API and the implementation?