From: Michal Hocko <mhocko@suse.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-mm@kvack.org, Dave Chinner <david@fromorbit.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
Uladzislau Rezki <urezki@gmail.com>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Ilya Dryomov <idryomov@gmail.com>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH 2/4] mm/vmalloc: add support for __GFP_NOFAIL
Date: Tue, 26 Oct 2021 13:29:00 +0200 [thread overview]
Message-ID: <YXfmfKDYE2P1LTUv@dhcp22.suse.cz> (raw)
In-Reply-To: <163524425265.8576.7853645770508739439@noble.neil.brown.name>
On Tue 26-10-21 21:30:52, Neil Brown wrote:
> On Tue, 26 Oct 2021, Michal Hocko wrote:
> > On Tue 26-10-21 09:59:36, Neil Brown wrote:
> > > On Tue, 26 Oct 2021, Michal Hocko wrote:
> > [...]
> > > > @@ -3032,6 +3036,10 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
> > > > warn_alloc(gfp_mask, NULL,
> > > > "vmalloc error: size %lu, vm_struct allocation failed",
> > > > real_size);
> > > > + if (gfp_mask & __GFP_NOFAIL) {
> > > > + schedule_timeout_uninterruptible(1);
> > > > + goto again;
> > > > + }
> > >
> > > Shouldn't the retry happen *before* the warning?
> >
> > I've done it after to catch the "depleted or fragmented" vmalloc space.
> > This is not related to the memory available and therefore it won't be
> > handled by the oom killer. The error message shouldn't imply the vmalloc
> > allocation failure IMHO but I am open to suggestions.
>
> The word "failed" does seem to imply what you don't want it to imply...
>
> I guess it is reasonable to have this warning, but maybe add " -- retrying"
> if __GFP_NOFAIL.
I do not have a strong opinion on that. I can surely do
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 602649919a9d..3489928fafa2 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -3033,10 +3033,11 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
VM_UNINITIALIZED | vm_flags, start, end, node,
gfp_mask, caller);
if (!area) {
+ bool nofail = gfp_mask & __GFP_NOFAIL;
warn_alloc(gfp_mask, NULL,
- "vmalloc error: size %lu, vm_struct allocation failed",
- real_size);
- if (gfp_mask & __GFP_NOFAIL) {
+ "vmalloc error: size %lu, vm_struct allocation failed%s",
+ real_size, (nofail) ? ". Retrying." : "");
+ if (nofail) {
schedule_timeout_uninterruptible(1);
goto again;
}
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-10-26 11:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 15:02 [PATCH 0/4] extend vmalloc support for constrained allocations Michal Hocko
2021-10-25 15:02 ` [PATCH 1/4] mm/vmalloc: alloc GFP_NO{FS,IO} for vmalloc Michal Hocko
2021-10-25 15:02 ` [PATCH 2/4] mm/vmalloc: add support for __GFP_NOFAIL Michal Hocko
2021-10-25 22:59 ` NeilBrown
2021-10-26 7:03 ` Michal Hocko
2021-10-26 10:30 ` NeilBrown
2021-10-26 11:29 ` Michal Hocko [this message]
2021-10-26 15:48 ` Uladzislau Rezki
2021-10-26 16:28 ` Michal Hocko
2021-10-26 19:33 ` Uladzislau Rezki
2021-10-27 6:46 ` Michal Hocko
2021-10-27 17:55 ` Uladzislau Rezki
2021-10-29 7:57 ` Michal Hocko
2021-10-29 14:05 ` Uladzislau Rezki
2021-10-29 14:45 ` Michal Hocko
2021-10-29 17:23 ` Uladzislau Rezki
2021-10-25 15:02 ` [PATCH 3/4] mm/vmalloc: be more explicit about supported gfp flags Michal Hocko
2021-10-25 23:26 ` NeilBrown
2021-10-26 7:10 ` Michal Hocko
2021-10-26 10:43 ` NeilBrown
2021-10-26 12:20 ` Michal Hocko
2021-10-25 15:02 ` [PATCH 4/4] mm: allow !GFP_KERNEL allocations for kvmalloc Michal Hocko
2021-10-25 23:34 ` NeilBrown
2021-10-26 7:15 ` Michal Hocko
2021-10-26 10:48 ` NeilBrown
2021-10-26 12:23 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXfmfKDYE2P1LTUv@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).