From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 389DFC433F5 for ; Fri, 26 Nov 2021 00:02:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B82B6B0072; Thu, 25 Nov 2021 19:02:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 367736B0078; Thu, 25 Nov 2021 19:02:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22EB86B007B; Thu, 25 Nov 2021 19:02:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 0FB0D6B0072 for ; Thu, 25 Nov 2021 19:02:07 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BE6C81855DCC1 for ; Fri, 26 Nov 2021 00:01:56 +0000 (UTC) X-FDA: 78849128232.06.15F8ABF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 6F5F0900053D for ; Fri, 26 Nov 2021 00:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637884854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0fqUjxGJvAmNwh+9GycDzUAaW22WJkGJ7g2kBi0jBnA=; b=igqa0aaS3oIPkR0vnhp5z7HfaGuoUWKV3yRJlXxnO9gePDqcbxMCA1kssum1GlRceb+3ZI BE56QGlEg21fL25AFbMwZI6iq/v0bDHVQU1wVFvvG3WmtvGpQhafvT/JQx88fXCjNdqU0s 1ElnEaiw81IJMd1uLJo0yiGCsxGgbDQ= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-25-5SOAwpBYPviafZ4zFCngKw-1; Thu, 25 Nov 2021 19:00:53 -0500 X-MC-Unique: 5SOAwpBYPviafZ4zFCngKw-1 Received: by mail-pl1-f198.google.com with SMTP id p24-20020a170902a41800b001438d6c7d71so2829066plq.7 for ; Thu, 25 Nov 2021 16:00:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0fqUjxGJvAmNwh+9GycDzUAaW22WJkGJ7g2kBi0jBnA=; b=4KQDmQ89ly+mta+EIRa86g8dPUc4eKPMhRnURmYOL06lFO5m4+J5Lep8nWALSIdq91 EH4sEvVtpTRIsLbf72YZyEqhoyBzDzS6RQLB3dCsSp8gNl1Uum5iNRSXsFuoZtw2Tqzu gVQqzQ6TXhurm/dc8CZGgQUKfA95yOaN9LYrgILBK+aHM96A5yenhib/8iMfP1gUl9v+ 08PGSEDONzt8eKILsxDPu1akQTuITLmyvV7srrdkh5X77ZVPfWqAoCcMqBugeV8i3ZJF c3cquhQ9dtkhf9EjctdZKN6DNm97Iz2AOVDnu+Ysdv9OGglUUk6biCRQ09GY3AjaYyOB MW3A== X-Gm-Message-State: AOAM530kCun6JyoRlEwglDb7JhheI/xyqvJnNsCtgsFjdJ/ThItLW3oS w/imTcKJpUz7yN0H+ICpL75hJmvnolC8yuuuBOMBs/J+C4W75AbKJ20ZvCa/3G/BYDAiq2SHvjM lnBXEcNOwAj0= X-Received: by 2002:a17:902:e547:b0:141:ddbc:a8d6 with SMTP id n7-20020a170902e54700b00141ddbca8d6mr34238854plf.27.1637884852212; Thu, 25 Nov 2021 16:00:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxugDhZXUCujZt/BGJr90/hD7civMzObjEEBQ1B3/fLPPeUdpRiGWVp+WALh3ykiP0XE9Nb5A== X-Received: by 2002:a17:902:e547:b0:141:ddbc:a8d6 with SMTP id n7-20020a170902e54700b00141ddbca8d6mr34238830plf.27.1637884851916; Thu, 25 Nov 2021 16:00:51 -0800 (PST) Received: from xz-m1.local ([94.177.118.150]) by smtp.gmail.com with ESMTPSA id k14sm4579753pff.6.2021.11.25.16.00.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 16:00:51 -0800 (PST) Date: Fri, 26 Nov 2021 08:00:44 +0800 From: Peter Xu To: Shakeel Butt Cc: David Hildenbrand , "Kirill A . Shutemov" , Yang Shi , Zi Yan , Matthew Wilcox , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: split thp synchronously on MADV_DONTNEED Message-ID: References: <1b30d06d-f9c0-1737-13e6-2d1a7d7b8507@redhat.com> <92fe0c31-b083-28c4-d306-da8a3cd891a3@redhat.com> <1b400921-8bef-8073-10f9-a7cbb09cfefe@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: t3fx1t4bg4w9caa3brarsd745izdstn8 X-Rspamd-Queue-Id: 6F5F0900053D X-Rspamd-Server: rspam07 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=igqa0aaS; spf=none (imf28.hostedemail.com: domain of peterx@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1637884855-655330 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 25, 2021 at 09:14:30AM -0800, Shakeel Butt wrote: > On Thu, Nov 25, 2021 at 2:09 AM Peter Xu wrote: > > > [...] > > > > Hi, Shakeel, > > > > I saw your v2 has started to pass in zap_details, then we need know the side > > effect on that skip-swap-entry thing because with your v2 code munmap() will > > start to skip swap entry too (while it was not before). > > > > I saw that you didn't mention this in v2 patch either in commit message or > > code, not sure whether you digged that up. I think it needs some double check > > (or feel free to start this digging by reviewing my small patch above :). > > > > I remember mentioning in the patch that this has dependency on your > rfc patch. Just checked again and yeah I only mentioned in the > 'changes since v1' section. I will add it more explicitly in the > following versions. Apologize for missing that section. Yeah depending on that patch should work. > > I will take a close look at your patch as well. Thanks a lot, -- Peter Xu