From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA4FC433FE for ; Mon, 24 Jan 2022 08:56:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD9466B0083; Mon, 24 Jan 2022 03:56:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C87616B0085; Mon, 24 Jan 2022 03:56:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B76716B0087; Mon, 24 Jan 2022 03:56:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id A941C6B0083 for ; Mon, 24 Jan 2022 03:56:46 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5F6D88249980 for ; Mon, 24 Jan 2022 08:56:46 +0000 (UTC) X-FDA: 79064575212.31.F4627AB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf01.hostedemail.com (Postfix) with ESMTP id 928FA4004C for ; Mon, 24 Jan 2022 08:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=egI+y7AO8wKr4Y2T/LgBNkccAOtCyUbyUckfPi3yE8o=; b=trRSnqkVoDGjPRY1W18iMn49qk mg1UC8X4zJbTpmEVmtNAbiBsOKnUIIY/pOk769eL0IGGxbssBjv4T/Rkg3a/aEh9s38XzscNkxFbX j2c2Ii/S3ifNhKDup9bsQhDRTqhF20cAxo3YbY3VnwBEbOk1FB1qARRpoMZq8BN5CKsIY+JRw+BoO 5XsWPOMayez0ojqr58rVp+a7qeQ0m+fq/z52HH31t6gLMLwPoiTza9TEr9lA5TtbNk40rqeC+I/h+ rtDre+QH2UK3W7G/9vg0OkQUTjuhBw1nRiOJjjZ6ccIU+QcFFF+Cb5mncKdT+d7RdO/n01weV2uTH zgx/3Vfw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBv9T-002hBP-HM; Mon, 24 Jan 2022 08:56:39 +0000 Date: Mon, 24 Jan 2022 00:56:39 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/23] NFS: remove IS_SWAPFILE hack Message-ID: References: <164299573337.26253.7538614611220034049.stgit@noble.brown> <164299611280.26253.6924680050876339981.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164299611280.26253.6924680050876339981.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: nil X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 928FA4004C X-Stat-Signature: 7i4xhu6waj315a6bhq4xrx5qwhtzdk34 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=trRSnqkV; spf=none (imf01.hostedemail.com: domain of BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1643014605-655029 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 24, 2022 at 02:48:32PM +1100, NeilBrown wrote: > This code is pointless as IS_SWAPFILE is always defined. > So remove it. > > Suggested-by: Mark Hemment > Signed-off-by: NeilBrown Looks good, Reviewed-by: Christoph Hellwig