From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C21D8C433F5 for ; Mon, 24 Jan 2022 08:58:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 533C26B0081; Mon, 24 Jan 2022 03:58:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BD656B0083; Mon, 24 Jan 2022 03:58:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 385B56B0085; Mon, 24 Jan 2022 03:58:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 28AB56B0081 for ; Mon, 24 Jan 2022 03:58:48 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CE8781802B4B4 for ; Mon, 24 Jan 2022 08:58:47 +0000 (UTC) X-FDA: 79064580294.23.E8AC970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id F1CE94000A for ; Mon, 24 Jan 2022 08:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+ySTjNm9z9t3kgl+0pVCQkj5RywfpxKfoIQtaXpG9uc=; b=IWAffQclXiKQ04DBXVF0j1T5xN +csiZpbA/hI5XtfeIkdyeRe068vzkV5I0KXb4I9apUSQL+tLnUbxzqJj3dM0JIC5TfcS80IHokACg 0TlgFYEzb3j3WaLcyJ/lHFO9GRxBWaA1s/qXFrVuuKgUk8TjEOvHcqUjev4hiSvEw4HHbw+rdDxAQ Ujc9HqfCiHtrmfxflUUHouP5t/3On+6N0uhigSS/zCEumW0HqzouCies/msMy8n7Wuuo6tf2i7NhZ Y1uAhwUgiaURKCCBu91P0gX0R074yks9L2FE4KErZlhM6NPJUUQY2BsoDYnJFYCxGre8RnlEZgHCe T0C/jG+Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBvBQ-002hvV-Cz; Mon, 24 Jan 2022 08:58:40 +0000 Date: Mon, 24 Jan 2022 00:58:40 -0800 From: Christoph Hellwig To: NeilBrown Cc: Trond Myklebust , Anna Schumaker , Chuck Lever , Andrew Morton , Mel Gorman , Christoph Hellwig , David Howells , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/23] NFS: swap IO handling is slightly different for O_DIRECT IO Message-ID: References: <164299573337.26253.7538614611220034049.stgit@noble.brown> <164299611281.26253.15560926531007295753.stgit@noble.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <164299611281.26253.15560926531007295753.stgit@noble.brown> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: nil X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F1CE94000A X-Stat-Signature: 1b4y6wrdrreu8nw6n4od1c6q3xwmdg57 Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=IWAffQcl; spf=none (imf17.hostedemail.com: domain of BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+b18af077b488c69bdec9+6728+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none X-HE-Tag: 1643014726-99881 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Same comment on the externs as for the previous one, but otherwise looks good: Reviewed-by: Christoph Hellwig