From: Matthew Wilcox <willy@infradead.org>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Yury Norov <yury.norov@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nicholas Piggin <npiggin@gmail.com>,
Ding Tianhong <dingtianhong@huawei.com>,
Alexey Klimov <aklimov@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Uladzislau Rezki <urezki@gmail.com>
Subject: Re: [PATCH] vmap(): don't allow invalid pages
Date: Thu, 20 Jan 2022 04:27:35 +0000 [thread overview]
Message-ID: <Yejkt/dpUKsaAu4t@casper.infradead.org> (raw)
In-Reply-To: <5b62ed03-8da8-a94d-cc48-a8cac1eae1c9@arm.com>
On Thu, Jan 20, 2022 at 09:07:11AM +0530, Anshuman Khandual wrote:
>
>
> On 1/19/22 10:52 PM, Yury Norov wrote:
> >> Why should not this just scan over the entire user provided struct page
> >> array and make sure that all pages there in are valid via above method,
> >> but in vmap() itself before calling vmap_pages_range(). Because seems
> >> like a single invalid page detected in vmap_pages_pte_range() will
> >> anyways abort the entire vmap(). This will also enable us to drop the
> >> existing NULL check above.
> >
> > I can do this, but why is it any better than the current approach?
>
> Because it will just return on the first instance where the valid page
> check fails, saving us some CPU cycles and an incomplete mapping ?
The valid page check is never intended to fail! If you're worried about
the efficiency of doing this, you have seriously confused your priorities.
next prev parent reply other threads:[~2022-01-20 4:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 23:52 [PATCH] vmap(): don't allow invalid pages Yury Norov
2022-01-19 0:51 ` Matthew Wilcox
2022-01-19 6:17 ` Anshuman Khandual
2022-01-19 17:22 ` Yury Norov
2022-01-20 3:37 ` Anshuman Khandual
2022-01-20 4:27 ` Matthew Wilcox [this message]
2022-01-21 2:56 ` Yury Norov
2022-01-19 11:16 ` Mark Rutland
2022-01-19 17:00 ` Yury Norov
2022-01-19 18:06 ` Mark Rutland
2022-01-19 13:28 ` Robin Murphy
2022-01-19 16:27 ` Matthew Wilcox
2022-01-19 17:54 ` Russell King (Oracle)
2022-01-19 18:01 ` Matthew Wilcox
2022-01-19 18:57 ` Russell King (Oracle)
2022-01-19 19:35 ` Matthew Wilcox
2022-01-19 22:38 ` Russell King (Oracle)
2022-01-19 18:43 ` Robin Murphy
2022-01-19 19:12 ` Russell King (Oracle)
2022-01-20 12:22 ` Robin Murphy
2022-01-20 13:03 ` Russell King (Oracle)
2022-01-20 16:37 ` Robin Murphy
2022-01-20 16:54 ` Russell King (Oracle)
2022-01-20 19:04 ` Matthew Wilcox
2022-01-21 5:26 ` Yury Norov
2022-01-26 2:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yejkt/dpUKsaAu4t@casper.infradead.org \
--to=willy@infradead.org \
--cc=aklimov@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dingtianhong@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=urezki@gmail.com \
--cc=will@kernel.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).