From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A05C433EF for ; Tue, 25 Jan 2022 14:40:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDA8C6B0085; Tue, 25 Jan 2022 09:40:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B890D6B0087; Tue, 25 Jan 2022 09:40:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A51086B0088; Tue, 25 Jan 2022 09:40:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay031.a.hostedemail.com [64.99.140.31]) by kanga.kvack.org (Postfix) with ESMTP id 9264F6B0085 for ; Tue, 25 Jan 2022 09:40:42 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3DA1D9D4 for ; Tue, 25 Jan 2022 14:40:42 +0000 (UTC) X-FDA: 79069070724.03.F600250 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by imf14.hostedemail.com (Postfix) with ESMTP id 80D8110000B for ; Tue, 25 Jan 2022 14:40:41 +0000 (UTC) Received: by mail-qk1-f178.google.com with SMTP id a12so9744877qkk.9 for ; Tue, 25 Jan 2022 06:40:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gtrPmzwuc49PRDcKSoMWbGgV3vDQg/A9aITmSjuzp5c=; b=g1fQpKeNAHgn9G8Omr0cljidyKQ3ENNVBrAJmALmgqehDrb40DaX8BQY+PzqLEJeq9 8Ju+pVg6yx3/nYZnsCiCAKOgJpFO/o081p79KVhTcRQvnPfVGP/YOgiFLNt49d8W5kO1 UACjHga4PuMhduxst5D7SG1SwibPnayMnti2RB3KciYWwdVKcemFTgb9ptcd6jMVmT46 HsQjEm6PGHOjarzAf1htN0pDGqxw728n7mhMAHtU1PnquagyK4d9aFCLHTASS7YSFnX/ PTSKGqGAi1nGvMcgALpHVkDsxVp6eLJ17WuWrI59bAFNYAyqjaylr9Sq99tHNG9rY+mH ifpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gtrPmzwuc49PRDcKSoMWbGgV3vDQg/A9aITmSjuzp5c=; b=oV4yb35hXB6cmRzjXYxWLhbAb4p/L8jiwjp6jYw4fiyb758VdQO0YYsk2NLEMweK6+ UMauhfxKYZSrqByG7RFrHZKGVobmPf4ibEs694/1FslvdRCRY0B5dRLqax1lhYn2xyZ4 AJ4f9OmSuXrQe8gXoqUdFxte8KHj+S7Mj/gwY/FF9huc5W3c20TxTuN64Eytl6A/vqaJ 98cLu/smzym6KVUuzsDBQBmnukjJINtiVX6HO7cdapUc1Evtjf0VckfzZ2YQtNvtkBcg 9hvPK3pQ6zKWVEBqxSMxtQYEEssk5gvetpexzsenl6Spvao0zrvxEhvpIzA7r6clnzTZ DzHQ== X-Gm-Message-State: AOAM530dae0MNUFw3BxP77vqKpU66IUaFcunW7WlXWRXpdPP2lUbNo7m jQJ1LOylKXU2mUHbLx1Tvw2aUA== X-Google-Smtp-Source: ABdhPJyRZolfkQavX9zknwnVBh+FWcx40CHIQtmwXZZ7myvC9M8hi9kfamtRYMhgnfy90nzpnZEcsQ== X-Received: by 2002:a05:620a:56a:: with SMTP id p10mr1893232qkp.102.1643121640735; Tue, 25 Jan 2022 06:40:40 -0800 (PST) Received: from localhost (cpe-98-15-154-102.hvc.res.rr.com. [98.15.154.102]) by smtp.gmail.com with ESMTPSA id h10sm9606707qko.90.2022.01.25.06.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 06:40:40 -0800 (PST) Date: Tue, 25 Jan 2022 09:40:39 -0500 From: Johannes Weiner To: Huangzhaoyang Cc: Suren Baghdasaryan , Peter Zijlstra , Zhaoyang Huang , Ingo Molnar , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4] psi: fix possible trigger missing in the window Message-ID: References: <1643093818-19835-1-git-send-email-huangzhaoyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1643093818-19835-1-git-send-email-huangzhaoyang@gmail.com> X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 80D8110000B X-Stat-Signature: jhwmap5p5u3r381yh4f6b55grs7uqj89 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=g1fQpKeN; spf=pass (imf14.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.178 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org X-HE-Tag: 1643121641-1308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 25, 2022 at 02:56:58PM +0800, Huangzhaoyang wrote: > From: Zhaoyang Huang > > When a new threshold breaching stall happens after a psi event was > generated and within the window duration, the new event is not > generated because the events are rate-limited to one per window. If > after that no new stall is recorded then the event will not be > generated even after rate-limiting duration has passed. This is > happening because with no new stall, window_update will not be called > even though threshold was previously breached. To fix this, record > threshold breaching occurrence and generate the event once window > duration is passed. > > Suggested-by: Suren Baghdasaryan > Signed-off-by: Zhaoyang Huang Acked-by: Johannes Weiner