From: Mike Rapoport <rppt@kernel.org>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/sparse: make mminit_validate_memmodel_limits() static
Date: Thu, 27 Jan 2022 14:45:06 +0200 [thread overview]
Message-ID: <YfKT0hs5C7Mr015v@kernel.org> (raw)
In-Reply-To: <20220127093221.63524-1-linmiaohe@huawei.com>
On Thu, Jan 27, 2022 at 05:32:21PM +0800, Miaohe Lin wrote:
> It's only used in the sparse.c now. So we can make it static and further
> clean up the relevant code.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> mm/internal.h | 11 -----------
> mm/sparse.c | 2 +-
> 2 files changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/mm/internal.h b/mm/internal.h
> index 4c2d06a2f50b..927dfba5111f 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -572,17 +572,6 @@ static inline void mminit_verify_zonelist(void)
> }
> #endif /* CONFIG_DEBUG_MEMORY_INIT */
>
> -/* mminit_validate_memmodel_limits is independent of CONFIG_DEBUG_MEMORY_INIT */
> -#if defined(CONFIG_SPARSEMEM)
> -extern void mminit_validate_memmodel_limits(unsigned long *start_pfn,
> - unsigned long *end_pfn);
> -#else
> -static inline void mminit_validate_memmodel_limits(unsigned long *start_pfn,
> - unsigned long *end_pfn)
> -{
> -}
> -#endif /* CONFIG_SPARSEMEM */
> -
> #define NODE_RECLAIM_NOSCAN -2
> #define NODE_RECLAIM_FULL -1
> #define NODE_RECLAIM_SOME 0
> diff --git a/mm/sparse.c b/mm/sparse.c
> index d21c6e5910d0..952f06d8f373 100644
> --- a/mm/sparse.c
> +++ b/mm/sparse.c
> @@ -126,7 +126,7 @@ static inline int sparse_early_nid(struct mem_section *section)
> }
>
> /* Validate the physical addressing limitations of the model */
> -void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn,
> +static void __meminit mminit_validate_memmodel_limits(unsigned long *start_pfn,
> unsigned long *end_pfn)
> {
> unsigned long max_sparsemem_pfn = 1UL << (MAX_PHYSMEM_BITS-PAGE_SHIFT);
> --
> 2.23.0
>
>
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2022-01-27 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 9:32 [PATCH] mm/sparse: make mminit_validate_memmodel_limits() static Miaohe Lin
2022-01-27 12:45 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfKT0hs5C7Mr015v@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).