From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A8FC433F5 for ; Fri, 28 Jan 2022 13:11:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B3746B0071; Fri, 28 Jan 2022 08:11:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 861D46B0073; Fri, 28 Jan 2022 08:11:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 779A86B0083; Fri, 28 Jan 2022 08:11:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id 620256B0071 for ; Fri, 28 Jan 2022 08:11:30 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2690494FDF for ; Fri, 28 Jan 2022 13:11:30 +0000 (UTC) X-FDA: 79079732340.10.2794E94 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id B143F40012 for ; Fri, 28 Jan 2022 13:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=3qDIrPC1sd2mSZKvlKsgL9uxMifmMEKbthxfAkSx5kA=; b=u1WPBHt/xVQRP0HWO1mc1wHJGN 5DKe/hG+F+5u3KyOeuksDGT6En82LF5qy2V7H2xlqOWTGJRx+iE7YG/bZ7TU9lnuJZcDHyqyvjtkm cvbYycJ2bqaQesHgp+KXus+6yWYgPhZ1uGCoNxuWoDx3Wefg4Vv98QB7ZQIsly7zRwAqYczrlCjbI yzIEKcMoFKxKyc8PIZplw30y68SJlrTBi+uy8Q873ffGFq3Wb5iug9vaGcii+BbNKCOIaLpc+PAns cBuddHt3OTYu53VrRTLVqavBhqCMdnm8V+OxkXS8e8b4L78evGCG2ei3JCWCLvtUHEOWOp+E6Ah82 F0qO9ptw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDR2G-006Q6f-C0; Fri, 28 Jan 2022 13:11:28 +0000 Date: Fri, 28 Jan 2022 13:11:28 +0000 From: Matthew Wilcox To: Karolina Drobnik Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 10/16] memblock tests: Add skeleton of the memblock simulator Message-ID: References: <92442409bbc72476509a2ceb2e182473ac69612b.1643206612.git.karolinadrobnik@gmail.com> <78c62135ee4bc56ae144b266ffaabe8d2afb2928.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <78c62135ee4bc56ae144b266ffaabe8d2afb2928.camel@gmail.com> X-Rspam-User: nil X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B143F40012 X-Stat-Signature: me9nh7zs9rqs4pcijucxmefcyr1ec9wq Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="u1WPBHt/"; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1643375489-722498 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.022867, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 28, 2022 at 12:25:55PM +0100, Karolina Drobnik wrote: > On Thu, 2022-01-27 at 14:06 +0000, Matthew Wilcox wrote: > > On Thu, Jan 27, 2022 at 02:21:28PM +0100, Karolina Drobnik wrote: > > > +# Memblock simulator requires AddressSanitizer (libasan) and > > > liburcu libraries > >=20 > > Stale comment?=A0 You don't seem to actually use liburcu. >=20 > I'm using uatomic_inc and uatomic_dec in tools/lib/slab.c. But, you're > right, memblock simulator doesn't use liburcu per se but uses code that > requires it. I wasn't sure where and how to communicate it, so I added > this comment here. I thought the comment was stale because you don't link against liburcu. Maybe you can use uatomic_inc() without adding -lurcu to the link step.