From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C838CC433F5 for ; Fri, 4 Feb 2022 07:25:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AF976B0072; Fri, 4 Feb 2022 02:25:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25F1A6B0073; Fri, 4 Feb 2022 02:25:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14E936B0074; Fri, 4 Feb 2022 02:25:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 065C16B0072 for ; Fri, 4 Feb 2022 02:25:40 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ABB96182229F3 for ; Fri, 4 Feb 2022 07:25:39 +0000 (UTC) X-FDA: 79104262398.16.88F7ED8 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf12.hostedemail.com (Postfix) with ESMTP id 12EAD40003 for ; Fri, 4 Feb 2022 07:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pSIk8p85bexLoPQZFRwkv0+ES2itcgz4LVldLAyslFc=; b=ga7TLa31ECuvrOpogYl+VPdgMX lFCXWAWmUgaUUwfItnclfICRNswZH8D0CsGAOM0ulh1dTv+RDAcSHVX7KO8sdjzNnX4sDEW65NDjc bZyWb8QAfCxHpoab6WT2wkdkjCB9cj6SKtaTSieuKERGLW7SvC9/iJuKzCkPJ2WRrTe6VAME2Id83 OW3iQXjiqHhsVeSR5E0sAjt7wvZqIS0qNdfp1EAvcYGsfbwyvQqScCAI5+8GgpFyVTGd+3dsBgTXe dtpMlYofz3tj4GPBrp6wzNIfTV+QHcNeiMUwNZwR3DYIcTZMTuaibccRXG6WVjkAqzuWjfMlTr4Jw DaI96LSQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFsy9-003eFM-2M; Fri, 04 Feb 2022 07:25:21 +0000 Date: Thu, 3 Feb 2022 23:25:21 -0800 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Peter Xu , Jason Gunthorpe , David Hildenbrand , Lukas Bulwahn , Claudio Imbrenda , Christoph Hellwig , Matthew Wilcox , Jan Kara , "Kirill A . Shutemov" , Alex Williamson , Andrea Arcangeli , LKML , linux-mm@kvack.org Subject: Re: [PATCH v4 1/5] mm: Fix invalid page pointer returned with FOLL_PIN gups Message-ID: References: <20220204020010.68930-1-jhubbard@nvidia.com> <20220204020010.68930-2-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220204020010.68930-2-jhubbard@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 12EAD40003 X-Stat-Signature: wxczh5imrpgq7bczyou87kyrf8u4wwir Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=ga7TLa31; dmarc=none; spf=none (imf12.hostedemail.com: domain of BATV+4ebadeba186fc1416f9d+6739+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4ebadeba186fc1416f9d+6739+infradead.org+hch@bombadil.srs.infradead.org X-Rspam-User: nil X-HE-Tag: 1643959537-250437 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 03, 2022 at 06:00:06PM -0800, John Hubbard wrote: > From: Peter Xu > > Alex reported invalid page pointer returned with pin_user_pages_remote() from > vfio after upstream commit 4b6c33b32296 ("vfio/type1: Prepare for batched > pinning with struct vfio_batch"). This commit message uses overly long lines all over. Otherwise looks good: Reviewed-by: Christoph Hellwig